Merged
Conversation
Member
Author
|
(Tagged a couple of people for visibility, since this changes a release process.) |
p-linnane
approved these changes
Jun 11, 2024
Bo98
reviewed
Jun 11, 2024
Member
|
Makes sense, thanks for this @woodruffw! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves ruby-macho from a "William pushes it from his desktop" release process to a CI-managed one, with Trusted Publishing as the authentication mechanism.
Anybody with the ability to create releases on this repo can now release from it. The workflow itself is currently tied to the
rubygems.orgdeployment environment, to which we could add signoff restrictions as well.NB: I've already configured the Trusted Publisher for ruby-macho on RubyGems:
Closes #273