Even the existing test that I've just deleted seems to differ from install_name_tool's behaviour:

❯ otool -l libdupes.dylib | rg -A2 LC_RPATH
          cmd LC_RPATH
      cmdsize 24
         path dupe (offset 12)
❯ install_name_tool -rpath dupe dupe libdupes.dylib
❯ echo $?
0

Hmm, I wonder if install_name_tool's behavior changed beneath us. It wouldn't be the first time...

I was wondering that too! But I don't have access to an old Mac to check.

Neither do I anymore, unfortunately. I remember we did quite a bit of behavioral testing against install_name_tool during the initial development here, so it wouldn't surprise me if things have changed. But we'll continue our policy of roughly following those changes 🙂

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Have you had the chance to think about how you want to handle this, @woodruffw?

Sorry for the delay!

And yeah: I think I agree that this change is for the best.

No apologies necessary, and thanks!