Adding new segments to the listing.#432
Merged
woodruffw merged 3 commits intoHomebrew:masterfrom Jan 14, 2022
Merged
Conversation
Seems to me this could be done generally in the other direction by stripping off `__` so removing `SEG_` from the symbol and looking for the value prefixed __ could reduce the need for a dataset that isn't useful here.
Member
|
LGTM, just needs RuboCop fixes. Also, could you add |
Seems to me this could be done generally in the other direction by stripping off `__` so removing `SEG_` from the symbol and looking for the value prefixed __ could reduce the need for a dataset that isn't useful here.
woodruffw
reviewed
Jan 14, 2022
woodruffw
approved these changes
Jan 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems to me this could be done generally in the other direction by stripping off
__so removingSEG_from the symbol and looking for the value prefixed __ could reduce the need for a dataset that isn't useful here.