macho: require codesign! call to be done explicitly.#287
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Nov 10, 2020
MikeMcQuaid:codesign-tweaks
Merged
macho: require codesign! call to be done explicitly.#287MikeMcQuaid merged 1 commit intoHomebrew:masterfrom MikeMcQuaid:codesign-tweaks
codesign! call to be done explicitly.#287MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:codesign-tweaks
Conversation
As explained in Homebrew/brew#9040 (comment) I think it's more desirable to have the `codesign!` calls happen inside Homebrew/brew instead of inside `macho/tools` methods. This makes it easier for Homebrew to turn this functionality on/off, change what platforms are affected, etc. without needing to tag and vendor a new release each time.
7 tasks
Member
Author
|
Thanks both! |
Member
|
I'll cut another release this evening 🙂 |
|
@woodruffw Yes, a new release would be nice so work on Homebrew/brew#9040 can continue. |
Member
|
Opened and will merge #288 with the release momentarily. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As explained in Homebrew/brew#9040 (comment) I think it's more desirable to have the
codesign!calls happen inside Homebrew/brew instead of insidemacho/toolsmethods.This makes it easier for Homebrew to turn this functionality on/off, change what platforms are affected, etc. without needing to tag and vendor a new release each time.