MachO: downgrade codesigning failures to a warning#275
MachO: downgrade codesigning failures to a warning#275woodruffw merged 1 commit intoHomebrew:masterfrom
Conversation
|
We might also want to make the "resigning" output debug/verbose only. I thought it was pretty unexpected that it was resigning everything (as a normal user) |
MikeMcQuaid
left a comment
There was a problem hiding this comment.
I think all the lib/macho/tools.rb MachO.codesign! calls should be removed and done in the Homebrew/brew side instead. This would allow they to be done conditionally based on platform there and exceptions handled accordingly and differently depending on the call site.
| @@ -56,6 +56,6 @@ def self.codesign!(filename) | |||
| "--preserve-metadata=entitlements,requirements,flags,runtime", | |||
There was a problem hiding this comment.
Can this use quiet_system or some equivalent that doesn't show the output to users?
There was a problem hiding this comment.
This might be tough in just ruby-macho, since it doesn't have access to quiet_system or the other Homebrew helpers. We could use Open3 or another stdlib module to control the output streams here, though.
There was a problem hiding this comment.
We could use
Open3or another stdlib module to control the output streams here, though.
👍🏻
This turned out to cause problems with certain exotic dylibs. We should allow this to be caught by the consumer for recovery. refs Homebrew/brew#8922
a556ff4 to
75feba6
Compare
|
LGTM! |
This turned out to cause problems with certain exotic dylibs. Leaving this a warning should be safer instead.
refs Homebrew/brew#8922