Skip to content

sourcekitten: improve test & bump to 0.32.0#96932

Closed
jpsim wants to merge 8 commits intoHomebrew:masterfrom
jpsim:sourcekitten-better-test
Closed

sourcekitten: improve test & bump to 0.32.0#96932
jpsim wants to merge 8 commits intoHomebrew:masterfrom
jpsim:sourcekitten-better-test

Conversation

@jpsim
Copy link
Copy Markdown
Contributor

@jpsim jpsim commented Mar 15, 2022

As of jpsim/SourceKitten#728 there's now a way to run SourceKitten while avoiding XPC communication with SourceKit.

This should prevent the sandbox violations we were seeing before.

jpsim added 3 commits March 15, 2022 15:56
@jpsim
sourcekitten 0.32.0
691d3f3
@jpsim
Requires Xcode 12.0 to build
6a3ecbb
@jpsim
Improve SourceKitten test
b671f52 
As of jpsim/SourceKitten#728 there's now a way to run
SourceKitten while avoiding XPC communication with SourceKit.

This should prevent the sandbox violations we were seeing before.
@BrewTestBot BrewTestBot added the macos-only Formula depends on macOS label Mar 15, 2022
@jpsim
Copy link
Copy Markdown
Contributor Author

jpsim commented Mar 15, 2022

So this is interesting. This stronger test requires Xcode 13, even though SourceKitten still supports building with Xcode 12. I'll either check to see what version of Xcode is configured before running this additional test, or more likely in the near future SourceKitten will require Xcode 13 to build so I can just unconditionally run this stronger test.

@SMillerDev
Copy link
Copy Markdown
Member

SMillerDev commented Mar 15, 2022

AFAIR xcode 13 is installed on all CI nodes so that should be fine

@jpsim
Copy link
Copy Markdown
Contributor Author

jpsim commented Mar 15, 2022

Do you know the installation path? I can set it as DEVELOPER_DIR in the test.

@chenrui333 chenrui333 mentioned this pull request Mar 15, 2022
Closed
carlocab
carlocab reviewed Mar 16, 2022
View reviewed changes
@carlocab
Copy link
Copy Markdown
Member

carlocab commented Mar 16, 2022

Do you know the installation path? I can set it as DEVELOPER_DIR in the test.

You can use MacOS::Xcode.sdk_path I think.

@carlocab carlocab changed the title [sourcekitten] Improve test for SourceKitten sourcekitten: improve test fo Mar 16, 2022
@carlocab carlocab changed the title sourcekitten: improve test fo sourcekitten: improve test Mar 16, 2022
@jpsim @carlocab
Use MacOs::Xcode.version
bf566a5 
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
@jpsim jpsim changed the title sourcekitten: improve test sourcekitten: improve test & bump to 0.32.0 Mar 16, 2022
@jpsim
Copy link
Copy Markdown
Contributor Author

jpsim commented Mar 16, 2022

AFAIR xcode 13 is installed on all CI nodes so that should be fine

Xcode 13 requires macOS 11.3+, so it's not installed on the macOS 10.15 nodes.

@jpsim jpsim marked this pull request as ready for review March 16, 2022 02:42
carlocab
carlocab approved these changes Mar 16, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented Mar 16, 2022

🤖 A scheduled task has triggered a merge.

@jpsim jpsim deleted the sourcekitten-better-test branch March 16, 2022 12:02
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@carlocab carlocab carlocab approved these changes

Assignees

No one assigned

Labels

macos-only Formula depends on macOS outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jpsim @SMillerDev @carlocab @BrewTestBot