Conversation
|
Fix in Homebrew/homebrew-test-bot#695. |
Formula/pyside.rb
Outdated
There was a problem hiding this comment.
This looks wrong. Why does it still have the build prefix as the RPATH?
There was a problem hiding this comment.
Because here uses the setup.py script, from official README, cmake super project is for development convenience. setup.py sets CMAKE_INSTALL_PREFIX to buildpath/pyside3_build/p3.9, so does the rpath, official shiboken wheel also sets the rpath to the build path. In order to keep the directory layout same as previous pyside version, which is the test case expect , we need manually move these files...
There was a problem hiding this comment.
If upstream have changed the directory layout then we should probably just follow them.
d71c498 to
a9790fb
Compare
Formula/pyside.rb
Outdated
There was a problem hiding this comment.
This issue has been reported to upstream.
There was a problem hiding this comment.
Can you link to the upstream report?
Formula/pyside.rb
Outdated
There was a problem hiding this comment.
install_symlink to a file in another keg will create a link that references a Cellar path. We don't want that because it breaks on upgrades.
Use ln_s instead. See julia, include-what-you-use, or any formulae that depends on macos-term-size for examples.
Formula/pyside.rb
Outdated
There was a problem hiding this comment.
use (qt.opt_bin/x).relative_path_from(site_pyside/x).
|
Thanks, @paperchalice. Can we switch this to |
carlocab
left a comment
There was a problem hiding this comment.
Actually, never mind. I think there's a way to do it without moving pyside back to llvm@12.
|
🤖 A scheduled task has triggered a merge. |
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?