osquery: vendor boost 1.62.0 and depend on openssl#8290
osquery: vendor boost 1.62.0 and depend on openssl#8290ilovezfs wants to merge 1 commit intoHomebrew:masterfrom
Conversation
aa07624 to
a756691
Compare
|
Boost 1.63.0 breakage reported to osquery upstream here: osquery/osquery#2888. |
vendor Boost 1.62.0 since osquery is not yet compatible with 1.63.0 depend on openssl drop libressl dependency (as it wasn't actually being used anyway)
a756691 to
b55a68c
Compare
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Does this build all of Boost or just some of it? Given the vendoring and difficulty building a newer version I'm tempted to say we just boneyard this.
https://github.com/Homebrew/homebrew-core/pull/8290/files#diff-ef2935cce4dec080563243e3608d91b3R79 It only builds those three libraries, which is fast. As for boneyarding, analytics shows 1,340 installs in the last 30 days. |
|
Ok, cool, that's fine with me. Kinda regardless of the number of installs it feels a bit 💩 to be sitting on an old version for so long but I'm happy to leave it if you are. |
|
@MikeMcQuaid I recall that I was able to work around osquery/osquery#2362 by similarly vendoring a static aws, so that should still be a way to get it current again. |
Without the Boost vendoring, this was failing to build due to the Boost 1.63.0 upgrade: https://bot.brew.sh/job/Homebrew%20Testing/1209/version=el_capitan/console
Note that osquery 1.7.3 is several versions behind the current stable
version (2.2.1), which is also be broken with boost 1.63.0.
CC @theopolis