Skip to content

sqlite: update livecheck#79685

Merged
samford merged 2 commits intoHomebrew:masterfrom
carlocab:sqlite-livecheck
Jun 22, 2021
Merged

sqlite: update livecheck#79685
samford merged 2 commits intoHomebrew:masterfrom
carlocab:sqlite-livecheck

Conversation

@carlocab
Copy link
Copy Markdown
Member

@carlocab carlocab commented Jun 20, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

The existing regex no longer works.

@carlocab
sqlite: update livecheck
025917a 
The existing regex no longer works.
@carlocab carlocab added livecheck Issues or PRs related to livecheck CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Jun 20, 2021
@carlocab carlocab requested a review from samford June 20, 2021 21:40
carlocab
carlocab commented Jun 20, 2021
View reviewed changes
samford
samford reviewed Jun 21, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the format of the news page is a little inconsistent (i.e., we can't guarantee that all releases in the future will have a link in the heading), it may be more reliable to match the version from the "Latest Release" link on the homepage. Looking back on archive.org, the format of the link seems to remain the same over time, so it seems like a more stable target.

I added suggestions for this approach but we would also need to update the homepage to avoid the redirection. If you're good with all this, I can simply push a commit to incorporate these changes and save you the trouble.

@carlocab
Copy link
Copy Markdown
Member Author

carlocab commented Jun 22, 2021

I added suggestions for this approach but we would also need to update the homepage to avoid the redirection. If you're good with all this, I can simply push a commit to incorporate these changes and save you the trouble.

Go ahead.

@samford
Copy link
Copy Markdown
Member

samford commented Jun 22, 2021

My commit's part of this PR branch now. If you're good with the current state of this, I'll go ahead and merge it.

@carlocab
Copy link
Copy Markdown
Member Author

carlocab commented Jun 22, 2021

Ok by me.

@samford samford merged commit 1c8aa34 into Homebrew:master Jun 22, 2021
@carlocab carlocab deleted the sqlite-livecheck branch June 22, 2021 01:22
@cho-m cho-m mentioned this pull request Jun 22, 2021
Closed
@samford samford mentioned this pull request Jun 30, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samford samford samford approved these changes

Assignees

No one assigned

Labels

CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. livecheck Issues or PRs related to livecheck

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carlocab @samford