Skip to content

mytop: bump rev to match system perl#79674

Closed
gromgit wants to merge 1 commit intoHomebrew:masterfrom
gromgit:mytop/bump-rev
Closed

mytop: bump rev to match system perl#79674
gromgit wants to merge 1 commit intoHomebrew:masterfrom
gromgit:mytop/bump-rev

Conversation

@gromgit
Copy link
Copy Markdown
Contributor

@gromgit gromgit commented Jun 20, 2021

Addresses test error Expected /username\ you\ specified/ to match "ListUtil.c: loadable library and perl binaries are mismatched (got handshake key 0xc500080, needed 0xc400080)\n".

Also removed make test per brew audit complaint:

$ brew audit --strict --online --git --fix mytop
mytop:
  * 79: col 5: Formulae in homebrew/core (except e.g. cryptography, libraries) should not run build-time checks

In support of #79624.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Addresses test error `Expected /username\ you\ specified/ to match "ListUtil.c: loadable library and perl binaries are mismatched (got handshake key 0xc500080, needed 0xc400080)\n".`

Also remove "make test" per `brew audit` complaint.

In support of Homebrew#79624.
@BrewTestBot BrewTestBot added missing license Formula has a missing license which should be added perl Perl use is a significant feature of the PR or issue labels Jun 20, 2021
@gromgit gromgit mentioned this pull request Jun 20, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

🤖 A scheduled task has triggered a merge.

@gromgit gromgit deleted the mytop/bump-rev branch June 20, 2021 18:17
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 21, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

missing license Formula has a missing license which should be added outdated PR was locked due to age perl Perl use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants