Skip to content

CGAL 5.3#79150

Closed
maxGimeno wants to merge 1 commit intoHomebrew:masterfrom
maxGimeno:CGAL-Upgrade_to_5.3-maxGimeno
Closed

CGAL 5.3#79150
maxGimeno wants to merge 1 commit intoHomebrew:masterfrom
maxGimeno:CGAL-Upgrade_to_5.3-maxGimeno

Conversation

@maxGimeno
Copy link
Copy Markdown
Contributor

@maxGimeno maxGimeno commented Jun 11, 2021 •
edited
Loading

Upgrade CGAL to the version 5.3

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@SMillerDev SMillerDev added prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies do not merge labels Jun 11, 2021
@carlocab carlocab changed the title Upgrade CGAL to 5.3 CGAL 5.3-beta1 Jun 11, 2021
@carlocab
Copy link
Copy Markdown
Member

carlocab commented Jun 11, 2021

Please don't ignore the PR template. In particular, please modify your existing commit to use the preferred commit-message style for homebrew/core. We put the name of the formula first in commit-message headings. Refer to the documentation or the guidelines for contributing for more details.

@carlocab
Copy link
Copy Markdown
Member

carlocab commented Jun 11, 2021 

==> brew audit --tap=homebrew/core
==> FAILED
cgal:
  * Stable version URLs should not contain beta

@maxGimeno
Copy link
Copy Markdown
Contributor Author

maxGimeno commented Jun 11, 2021

If it is the only problem then it seems fine. For now it is just a draft to see if anything is needed before the release, then I'll update the adresses and names for the real 5.3 version.

@maxGimeno maxGimeno mentioned this pull request Jun 11, 2021
Closed
70 tasks
@carlocab
Copy link
Copy Markdown
Member

carlocab commented Jun 11, 2021 •
edited
Loading

Hard to say if that's the only problem since none of the other tests was run. Try adding

version "5.3"

right after the url line to try to get the rest of the tests to run. (Not sure if this will work.) Or you could probably add cgal here: https://github.com/Homebrew/homebrew-core/blob/master/audit_exceptions/unstable_allowlist.json

@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Jun 14, 2021
@maxGimeno maxGimeno force-pushed the CGAL-Upgrade_to_5.3-maxGimeno branch from 6beab05 to 3b206b8 Compare June 14, 2021 08:17
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 5, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Jul 5, 2021
@lrineau
Copy link
Copy Markdown
Contributor

lrineau commented Jul 6, 2021

I will publish CGAL-5.3 today, and this PR will be updated with the new release.

@maxGimeno maxGimeno marked this pull request as ready for review July 6, 2021 13:55
@maxGimeno maxGimeno changed the title CGAL 5.3-beta1 CGAL 5.3 Jul 6, 2021
carlocab
carlocab reviewed Jul 6, 2021
View reviewed changes
@maxGimeno maxGimeno force-pushed the CGAL-Upgrade_to_5.3-maxGimeno branch from cfb80b4 to 25f4cc0 Compare July 6, 2021 14:02
@BrewTestBot BrewTestBot removed the automerge-skip `brew pr-automerge` will skip this pull request label Jul 6, 2021
SMillerDev
SMillerDev approved these changes Jul 7, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maxGimeno ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@carlocab carlocab removed do not merge prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies stale No recent activity labels Jul 8, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented Jul 8, 2021

:shipit: @carlocab has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Aug 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@carlocab carlocab carlocab left review comments

@SMillerDev SMillerDev SMillerDev approved these changes

Assignees

No one assigned

Labels

outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@maxGimeno @carlocab @lrineau @BrewTestBot @SMillerDev