Skip to content

vtk: use #rpath#78220

Closed
carlocab wants to merge 1 commit intoHomebrew:masterfrom
carlocab:vtk-rpath
Closed

vtk: use #rpath#78220
carlocab wants to merge 1 commit intoHomebrew:masterfrom
carlocab:vtk-rpath

Conversation

@carlocab
Copy link
Copy Markdown
Member

@carlocab carlocab commented May 28, 2021

See #75458.

Also, use opt-path instead of a cellar path for the install name
directory, and make the inreplace call portable to Linux.

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@carlocab
vtk: use #rpath
ccb0c05 
See Homebrew#75458.

Also, use `opt`-path instead of a cellar path for the install name
directory, and make the `inreplace` call portable to Linux.
@BrewTestBot BrewTestBot added the python Python use is a significant feature of the PR or issue label May 28, 2021
@carlocab carlocab mentioned this pull request May 28, 2021
Closed
39 tasks
@carlocab
Copy link
Copy Markdown
Member Author

carlocab commented May 28, 2021 

==> Detecting if vtk--9.0.1_9.arm64_big_sur.bottle.1.tar.gz is relocatable...
Warning: String '/opt/homebrew/Cellar' still exists in these files:
/opt/homebrew/Cellar/vtk/9.0.1_9/lib/libvtklibproj-9.0.9.0.1.dylib
 --> match '/opt/homebrew/Cellar/vtk/9.0.1_9/' at offset 0x2f0d4

Aw, didn't work.

Still useful, though, since not having to relocate RPATHs speeds up bottling/pouring.

@carlocab
Copy link
Copy Markdown
Member Author

carlocab commented May 28, 2021 •
edited
Loading

caffe failure on Mojave and Catalina. We really should fix that test...

nandahkrishna
nandahkrishna approved these changes May 28, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@nandahkrishna nandahkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only caffe failed, I'll take a look at the test. Since it's timing out most of the time, using a smaller model could solve the problem.

@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented May 28, 2021

:shipit: @carlocab has triggered a merge.

@carlocab carlocab deleted the vtk-rpath branch May 28, 2021 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nandahkrishna nandahkrishna nandahkrishna approved these changes

Assignees

No one assigned

Labels

python Python use is a significant feature of the PR or issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlocab @BrewTestBot @nandahkrishna