Skip to content

monkeysphere: revision bump (perl shebang fix)#77242

Closed
carlocab wants to merge 1 commit intoHomebrew:masterfrom
carlocab:monkeysphere-perl
Closed

monkeysphere: revision bump (perl shebang fix)#77242
carlocab wants to merge 1 commit intoHomebrew:masterfrom
carlocab:monkeysphere-perl

Conversation

@carlocab
Copy link
Copy Markdown
Member

@carlocab carlocab commented May 14, 2021

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Fixes CI failure seen in #77228 and various other PRs.

See Homebrew/brew#11286.

@carlocab carlocab requested a review from Bo98 May 14, 2021 01:42
@BrewTestBot BrewTestBot added missing license Formula has a missing license which should be added perl Perl use is a significant feature of the PR or issue labels May 14, 2021
@carlocab carlocab mentioned this pull request May 14, 2021
Closed
@carlocab
Copy link
Copy Markdown
Member Author

carlocab commented May 14, 2021

Mojave and Catalina are audit failures for using http rather than https.

On Big Sur:

An exception occurred within a child process:
  Minitest::Assertion: Expected /We\ need\ at\ least/ to match "dyld: missing lazy symbol called\n".

On ARM:

Error: monkeysphere: failed
An exception occurred within a child process:
  Minitest::Assertion: Expected /We\ need\ at\ least/ to match "Can't load '/System/Library/Perl/Extras/5.30/darwin-thread-multi-2level/auto/Crypt/OpenSSL/RSA/RSA.bundle' for module Crypt::OpenSSL::RSA: dlopen(/System/Library/Perl/Extras/5.30/darwin-thread-multi-2level/auto/Crypt/OpenSSL/RSA/RSA.bundle, 0x0001): symbol '_ERR_load_crypto_strings' not found, expected in flat namespace by '/System/Library/Perl/Extras/5.30/darwin-thread-multi-2level/auto/Crypt/OpenSSL/RSA/RSA.bundle' at /System/Library/Perl/5.30/XSLoader.pm line 96.\n\u0000 at /System/Library/Perl/Extras/5.30/darwin-thread-multi-2level/Crypt/OpenSSL/RSA.pm line 14.\nCompilation failed in require at /opt/homebrew/Cellar/monkeysphere/0.44_4/bin/openpgp2pem line 54.\nBEGIN failed--compilation aborted at /opt/homebrew/Cellar/monkeysphere/0.44_4/bin/openpgp2pem line 54.\n".

Ideas, @Bo98?

@carlocab carlocab force-pushed the monkeysphere-perl branch from 6188447 to de91069 Compare May 14, 2021 02:06
@carlocab carlocab added the license License PRs label May 14, 2021
@carlocab
Copy link
Copy Markdown
Member Author

carlocab commented May 14, 2021

License ref: https://metadata.ftp-master.debian.org/changelogs//main/m/monkeysphere/monkeysphere_0.44-1_copyright

@BrewTestBot BrewTestBot removed the missing license Formula has a missing license which should be added label May 14, 2021
@Bo98
Copy link
Copy Markdown
Member

Bo98 commented May 14, 2021

What's the output of otool -L /System/Library/Perl/Extras/5.30/darwin-thread-multi-2level/auto/Crypt/OpenSSL/RSA/RSA.bundle and file /System/Library/Perl/Extras/5.30/darwin-thread-multi-2level/auto/Crypt/OpenSSL/RSA/RSA.bundle?

@carlocab
Copy link
Copy Markdown
Member Author

carlocab commented May 14, 2021 

❯ otool -L /System/Library/Perl/Extras/5.30/darwin-thread-multi-2level/auto/Crypt/OpenSSL/RSA/RSA.bundle
/System/Library/Perl/Extras/5.30/darwin-thread-multi-2level/auto/Crypt/OpenSSL/RSA/RSA.bundle:
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1292.100.5)
❯ file /System/Library/Perl/Extras/5.30/darwin-thread-multi-2level/auto/Crypt/OpenSSL/RSA/RSA.bundle
/System/Library/Perl/Extras/5.30/darwin-thread-multi-2level/auto/Crypt/OpenSSL/RSA/RSA.bundle: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit bundle x86_64] [arm64e:Mach-O 64-bit bundle arm64e]
/System/Library/Perl/Extras/5.30/darwin-thread-multi-2level/auto/Crypt/OpenSSL/RSA/RSA.bundle (for architecture x86_64):        Mach-O 64-bit bundle x86_64
/System/Library/Perl/Extras/5.30/darwin-thread-multi-2level/auto/Crypt/OpenSSL/RSA/RSA.bundle (for architecture arm64e):        Mach-O 64-bit bundle arm64e

@carlocab
monkeysphere: revision bump (perl shebang fix)
def2455 
Fixes CI failure seen in Homebrew#77228 and various other PRs. Also, update the
license, and use `https` in homepage.

See Homebrew/brew#11286.

License ref:

    https://metadata.ftp-master.debian.org/changelogs//main/m/monkeysphere/monkeysphere_0.44-1_copyright
@carlocab carlocab force-pushed the monkeysphere-perl branch from de91069 to def2455 Compare May 14, 2021 02:42
@Bo98
Copy link
Copy Markdown
Member

Bo98 commented May 14, 2021

uhh why is it not linking to libssl and libcrypto?

@Bo98
Copy link
Copy Markdown
Member

Bo98 commented May 14, 2021

Is the 5.28 bundle the same?

@carlocab
Copy link
Copy Markdown
Member Author

carlocab commented May 14, 2021 

❯ otool -L /System/Library/Perl/Extras/5.28/darwin-thread-multi-2level/auto/Crypt/OpenSSL/RSA/RSA.bundle
/System/Library/Perl/Extras/5.28/darwin-thread-multi-2level/auto/Crypt/OpenSSL/RSA/RSA.bundle:
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1292.100.5)
❯ file /System/Library/Perl/Extras/5.28/darwin-thread-multi-2level/auto/Crypt/OpenSSL/RSA/RSA.bundle
/System/Library/Perl/Extras/5.28/darwin-thread-multi-2level/auto/Crypt/OpenSSL/RSA/RSA.bundle: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit bundle x86_64] [arm64e:Mach-O 64-bit bundle arm64e]
/System/Library/Perl/Extras/5.28/darwin-thread-multi-2level/auto/Crypt/OpenSSL/RSA/RSA.bundle (for architecture x86_64):        Mach-O 64-bit bundle x86_64
/System/Library/Perl/Extras/5.28/darwin-thread-multi-2level/auto/Crypt/OpenSSL/RSA/RSA.bundle (for architecture arm64e):        Mach-O 64-bit bundle arm64e

@carlocab
Copy link
Copy Markdown
Member Author

carlocab commented May 14, 2021

5.18 is though:

❯ otool -L /System/Library/Perl/Extras/**/darwin-thread-multi-2level/auto/Crypt/OpenSSL/RSA/RSA.bundle
/System/Library/Perl/Extras/5.18/darwin-thread-multi-2level/auto/Crypt/OpenSSL/RSA/RSA.bundle:
        /usr/lib/libssl.46.dylib (compatibility version 47.0.0, current version 47.1.0)
        /usr/lib/libcrypto.44.dylib (compatibility version 45.0.0, current version 45.1.0)
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1292.100.5)
/System/Library/Perl/Extras/5.28/darwin-thread-multi-2level/auto/Crypt/OpenSSL/RSA/RSA.bundle:
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1292.100.5)
/System/Library/Perl/Extras/5.30/darwin-thread-multi-2level/auto/Crypt/OpenSSL/RSA/RSA.bundle:
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1292.100.5)

@carlocab
Copy link
Copy Markdown
Member Author

carlocab commented May 14, 2021

macOS perl seems broken 🙃

@Bo98
Copy link
Copy Markdown
Member

Bo98 commented May 14, 2021

I guess I'm writing a bug report tomorrow.

Resourcing Crypt::OpenSSL::RSA is a potential workaround.

@Bo98
Copy link
Copy Markdown
Member

Bo98 commented May 14, 2021 •
edited
Loading

Did this regress in 11.3 or something? We managed to build a bottle before and that would have been with 5.28.

@carlocab carlocab closed this May 16, 2021
@carlocab carlocab deleted the monkeysphere-perl branch May 16, 2021 19:11
@carlocab carlocab mentioned this pull request May 25, 2021
Closed
@cho-m cho-m mentioned this pull request Jun 4, 2021
Closed
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Bo98 Bo98 Awaiting requested review from Bo98

Assignees

No one assigned

Labels

license License PRs outdated PR was locked due to age perl Perl use is a significant feature of the PR or issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlocab @Bo98 @BrewTestBot