Error: git: failed
An exception occurred within a child process:
  Minitest::Assertion: Expected /Authentication\ Required/ to match "/private/tmp/5FIxnS0quw/0001-Second-Commit.patch\n(mbox) Adding cc: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com> from line 'From: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>'\nNot using SSL_VERIFY_PEER due to out-of-date IO::Socket::SSL.\nTo use SSL please install IO::Socket::SSL with version>=2.007 at /System/Library/Perl/5.28/Net/SMTP.pm line 268.\n".

https://github.com/Homebrew/homebrew-core/pull/76964/checks?check_run_id=2546546538#step:7:82

Probably fixed with Homebrew/brew#11360.

@Bo98, Can you apply the patch I mentioned in #76900?

This is used to build the subversion perl module for system perl only. And also build it on Apple Silicon.

Your patch probably needs to refer to /usr/bin/perl#{MacOS.preferred_perl_version} rather than just /usr/bin/perl.

VERSIONER_PERL_VERSION should in theory cover that.

subversion use homebrew's perl on not macOS, and git use perl in the PATH.
For macOS this will be fine, but I think this will make git-svn not working on not macOS?

git.rb:

    ENV["PERL_PATH"] = which("perl")
    on_macos do
      ENV["PERL_PATH"] = "/usr/bin/perl"
    end

subversion.rb:

    perl = Formula["perl"].opt_bin/"perl"
    on_macos do
      perl = "/usr/bin/perl"
    end

Yeah I've been talking to the Linux folk about Perl on Linux. There is a desire not to have Git depend on Perl (since it's an extra dependency on a critical component that brew can rely on).

The approach I took here clearly didn't work because:

on_macos cannot include uses_from_macos.

I mean that on Linux git depends on perl in the PATH, and subversion depends on homebrew's perl.
These two may not the same. So maybe on Linux git-svn is not working.
I think we should let subversion on Linux also depends on perl in the PATH.

like this:

    perl = which("perl")
    on_macos do
      perl = "/usr/bin/perl"
    end

Subversion already depends on brewed Perl on Linux so which("perl") will not change which Perl is used. Brewed Perl is kinda needed there since SVN builds native Perl modules and thus isn't compatible with versions of Perl not matching whatever it was built with.

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.