llvm@11: patch support for macOS 11.3+ SDK changes#76030
llvm@11: patch support for macOS 11.3+ SDK changes#76030Bo98 wants to merge 2 commits intoHomebrew:masterfrom
Conversation
| (libexec/"lib").install_symlink llvm.opt_lib/"clang" | ||
| (libexec/"include").install_symlink llvm.opt_include/"c++" |
There was a problem hiding this comment.
This doesn't help -- llvm.lib == llvm.opt_lib outside the llvm formula. We used to just copy the headers, but then eventually it still needed revision bumps anyway with minor llvm version bumps, so I figured going with symlinks worked better anyway.
There was a problem hiding this comment.
Ah yes.
I'll undo, but it will be interesting to see if a revision bump helps here at least.
There was a problem hiding this comment.
Seems like we were symlinking to the Cellar? c++ -> ../../../../llvm@11/11.1.0/include/c++
There was a problem hiding this comment.
Yea, not surprising. Revision bumps always help IWYU. Though I have to say I'm confused as to why it would now need one...
There was a problem hiding this comment.
Because if we are symlinking to the Cellar then the path is now 11.1.0_1 rather than 11.1.0.
There was a problem hiding this comment.
Ah, yes. We were symlinking to the cellar. I do remember noting that install_symlink seems a bit eager about resolving symlinks that you pass to it.
|
🤖 A scheduled task has triggered a merge. |
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?