Skip to content

various formulae: fix tests#75636

Merged
carlocab merged 9 commits intoHomebrew:masterfrom
carlocab:test-fixes
Apr 22, 2021
Merged

various formulae: fix tests#75636
carlocab merged 9 commits intoHomebrew:masterfrom
carlocab:test-fixes

Conversation

@carlocab
Copy link
Copy Markdown
Member

@carlocab carlocab commented Apr 21, 2021

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

s/assert_not/refute/

#75617, #75622, #75624, #75625, #75626

@carlocab carlocab enabled auto-merge (rebase) April 21, 2021 01:29
@carlocab carlocab added automerge-skip `brew pr-automerge` will skip this pull request bottle unneeded [DEPRECATED] Bottle does not need to be built labels Apr 21, 2021
@carlocab
Copy link
Copy Markdown
Member Author

carlocab commented Apr 21, 2021

ARM failure:

Error: 2 failed steps!
brew install --only-dependencies --verbose app-engine-java
brew install --verbose app-engine-java

Couldn't install openjdk@8, which has no ARM bottle.

@Moisan
Copy link
Copy Markdown
Member

Moisan commented Apr 21, 2021

app-engine-java is deprecated, I guess there is no need to update it.

@carlocab
Copy link
Copy Markdown
Member Author

carlocab commented Apr 21, 2021

Yup, but sed didn't know that. 😅 Easier to fix it with the rest now that CI is basically done here.

@carlocab carlocab added the ready to merge PR can be merged once CI is green label Apr 21, 2021
This was referenced Apr 21, 2021
Closed
Merged
@carlocab carlocab disabled auto-merge April 22, 2021 16:51
@carlocab carlocab requested a review from Moisan April 22, 2021 17:37
@carlocab carlocab merged commit 1eaaf0b into Homebrew:master Apr 22, 2021
@carlocab carlocab deleted the test-fixes branch April 22, 2021 19:41
@github-actions github-actions bot added the outdated PR was locked due to age label May 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Moisan Moisan Moisan approved these changes

Assignees

No one assigned

Labels

automerge-skip `brew pr-automerge` will skip this pull request bottle unneeded [DEPRECATED] Bottle does not need to be built outdated PR was locked due to age ready to merge PR can be merged once CI is green

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carlocab @Moisan