Skip to content

node@15 15.14.0 (new formula)#75598

Closed
derrabus wants to merge 1 commit intoHomebrew:masterfrom
derrabus:node-at-15
Closed

node@15 15.14.0 (new formula)#75598
derrabus wants to merge 1 commit intoHomebrew:masterfrom
derrabus:node-at-15

Conversation

@derrabus
Copy link
Copy Markdown
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Follow-up to #75595

brew audit --strict node@15 complains about a naming conflict with the alias of the same name, but that will go away as soon as #75595 is merged.

@BrewTestBot BrewTestBot added formula deprecated Formula deprecated legacy Relates to a versioned @ formula new formula PR adds a new formula to Homebrew/homebrew-core labels Apr 20, 2021
@carlocab
Copy link
Copy Markdown
Member

Do we need a node@15? We typically only keep versioned formulae if they're either a) still maintained, or b) needed by other formulae.

My understanding of the node version scheme is that node@15 will no longer be maintained, and I'm not sure other formulae will need this.

@derrabus
Copy link
Copy Markdown
Contributor Author

Node 15 will be maintained until June 1st, see https://nodejs.org/en/about/releases/

But that is of course a very short period of time. I would totally understand if the Homebrew projects decides against adding a dedicated node@15 formula.

@carlocab
Copy link
Copy Markdown
Member

carlocab commented Apr 20, 2021

Do you think users will find it useful? If there's a genuine use for it that you can't get for some reason with node@14 and node@16, then I won't be opposed to it. (I don't speak for other maintainers here though.)

If we do add it, though, we should probably already add the deprecate! line for when it's no longer supported. Oops, missed that you already did this.

@carlocab
Copy link
Copy Markdown
Member

It looks like some formulae failed the tests at #75595, so it may well be that they do need node@15.

@derrabus
Copy link
Copy Markdown
Contributor Author

Do you think users will find it useful? If there's a genuine use for it that you can't get for some reason with node@14 and node@16, then I won't be opposed to it. (I don't speak for other maintainers here though.)

If you look at the test failure of the node 16 bump, you can see at least one formula that is apparently not yet ready for node 16. Keeping Node 15 for a little while might smoothen the transition.

If we do add it, though, we should probably already add the deprecate! line for when it's no longer supported.

I've added this already.

@carlocab carlocab mentioned this pull request Apr 20, 2021
@Bo98
Copy link
Copy Markdown
Member

Bo98 commented Apr 21, 2021

Honestly, I'd rather just make jhipster depend on node@14.

Node 15 will only last another month while if we introduce this formula we would have to go through the full deprecation -> disabled -> removal process which takes much, much longer.

@derrabus
Copy link
Copy Markdown
Contributor Author

All right, let's close this PR then. 😃

@derrabus derrabus closed this Apr 21, 2021
@derrabus derrabus deleted the node-at-15 branch April 21, 2021 06:36
@stanislav-janu stanislav-janu mentioned this pull request May 3, 2021
@KristianH KristianH mentioned this pull request May 4, 2021
4 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label May 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

formula deprecated Formula deprecated legacy Relates to a versioned @ formula new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants