Conversation
|
Testing a VM inside of a VM (the CI) is probably going to be a problem here. |
|
Was there some progress on Big Sur that isn't yet reflected on moby/hyperkit#297 ? |
|
Yes, moby/hyperkit#307 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
If we can't test this in a sandbox, we may as well just get rid of the test block (or put in some trivial test that will work in a sandbox). The current bottles are failing tests anyway... |
IMO the best option would be to leave the test but skip it on CI -- that way it at least can be run manually as part of formula maintenance. However I haven't had luck in the past with getting changes like that past review: #66485 (comment) |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
There's been some changes so the VM environment so let's see if anything's changed here. |
Formula/hyperkit.rb
Outdated
There was a problem hiding this comment.
Would be good to add a comment here about how to update these when needed.
Did we not revsion bump |
|
Unfortunately not: #71942 But CI didn't pick anything up with |
I suppose if it only uses the binary then there's no issues. There'll only be issues if it actually uses it as a library, and This is certainly the first formula to use the |
|
Oops. We should probably add |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Tried another run with updated EDIT: Haven't been able to get test to work locally, though I am trying via Rosetta layer. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?