Skip to content

azure-cli: update cffi resource#68126

Closed
carlocab wants to merge 1 commit intoHomebrew:masterfrom
carlocab:azure-cli-v2
Closed

azure-cli: update cffi resource#68126
carlocab wants to merge 1 commit intoHomebrew:masterfrom
carlocab:azure-cli-v2

Conversation

@carlocab
Copy link
Copy Markdown
Member

@carlocab carlocab commented Jan 1, 2021 •
edited
Loading

Bug report: Homebrew/brew#10152 (comment)

I tried switching the URL to PyPI and using update-python-resources to update everything, but that lead to a build failure. The install block probably needs to be updated first before that works. In the meantime, this should at least fix the reported problem.

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@BrewTestBot BrewTestBot added the python Python use is a significant feature of the PR or issue label Jan 1, 2021
This was referenced Jan 1, 2021
Closed
Closed
@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented Jan 1, 2021

:shipit: @carlocab has triggered a merge.

Rylan12
Rylan12 approved these changes Jan 1, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should definitely try to transfer to the PyPI source so that issues like this can (hopefully) be avoided in the future. Especially for these formulae with huge numbers of resources.

@carlocab
Copy link
Copy Markdown
Member Author

carlocab commented Jan 1, 2021

Yep, sorry for not waiting for feedback on this one. However, the user who reported the bug confirmed that this fixed it, so I figured it was safe to merge.

I thought about fixing the install block to work with the PyPI URL, but:

  1. that would've delayed the fix; and,
  2. I was worried about breaking Azure CLI's CI, as they seem to have automated updates for it: Azure CLI 2.17.0 #67930

@carlocab carlocab deleted the azure-cli-v2 branch January 1, 2021 17:47
@carlocab carlocab mentioned this pull request Jan 1, 2021
Open
@carlocab
Copy link
Copy Markdown
Member Author

carlocab commented Jan 1, 2021

Followed up on the PyPI URL migration here: Azure/azure-cli#16388

@Rylan12
Copy link
Copy Markdown
Member

Rylan12 commented Jan 1, 2021

No worries. I was going to trigger the merge after I approved anyway.

I wouldn't worry at all about breaking their CI. We should do what's best for Homebrew. If their stuff doesn't work, we can just fix the branch manually or close and open our own PR.

@fengzhou-msft fengzhou-msft mentioned this pull request Jan 14, 2021
Merged
3 tasks
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 3, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Rylan12 Rylan12 Rylan12 approved these changes

Assignees

No one assigned

Labels

outdated PR was locked due to age python Python use is a significant feature of the PR or issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlocab @BrewTestBot @Rylan12