Skip to content

fixes python@3.9 gdbm build on ARM Mac#66458

Closed
YilinGUO wants to merge 1 commit intoHomebrew:masterfrom
YilinGUO:master
Closed

fixes python@3.9 gdbm build on ARM Mac#66458
YilinGUO wants to merge 1 commit intoHomebrew:masterfrom
YilinGUO:master

Conversation

@YilinGUO
Copy link
Copy Markdown

@YilinGUO YilinGUO commented Dec 8, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

related to #64869

The previous issue was

$ brew test python@3.9
==> Testing python@3.9
==> /opt/homebrew/Cellar/python@3.9/3.9.0_4/bin/python3.9 -c import sqlite3
==> /opt/homebrew/Cellar/python@3.9/3.9.0_4/bin/python3.9 -c import _gdbm
Last 15 lines from /var/brew/Library/Logs/Homebrew/python@3.9/test.02.python3.9:
2020-12-06 16:22:26 +0100

/opt/homebrew/Cellar/python@3.9/3.9.0_4/bin/python3.9
-c
import _gdbm

Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named '_gdbm'
Error: python@3.9: failed

Here in this commit should fix the real issue of not being able to find /opt/homebrew/Cellar/gdbm/1.18.1_1/lib/libgdbm.dylib

Passes the brew test on my M1 mac:

$brew test python
==> Testing python@3.9
==> /opt/homebrew/Cellar/python@3.9/3.9.0_4/bin/python3.9 -c import sqlite3
==> /opt/homebrew/Cellar/python@3.9/3.9.0_4/bin/python3.9 -c import tkinter; root = tkinter.Tk()
==> /opt/homebrew/Cellar/python@3.9/3.9.0_4/bin/python3.9 -c import _gdbm
==> /opt/homebrew/Cellar/python@3.9/3.9.0_4/bin/python3.9 -c import zlib
==> /opt/homebrew/Cellar/python@3.9/3.9.0_4/bin/pip3 list --format=columns

@YilinGUO YilinGUO mentioned this pull request Dec 8, 2020
Closed
5 tasks
@fxcoudert
Copy link
Copy Markdown
Member

fxcoudert commented Dec 8, 2020

Should now be fixed in #66438

@fxcoudert fxcoudert closed this Dec 8, 2020
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 7, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YilinGUO @fxcoudert @BrewTestBot