Skip to content

datasette 0.47.1 (new formula)#59494

Closed
simonw wants to merge 1 commit intoHomebrew:masterfrom
simonw:master
Closed

datasette 0.47.1 (new formula)#59494
simonw wants to merge 1 commit intoHomebrew:masterfrom
simonw:master

Conversation

@simonw
Copy link
Copy Markdown
Contributor

@simonw simonw commented Aug 12, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Datasette is an open source multi-tool for exploring and publishing data, written in Python.

I've made this formula available as a tap which can be installed like so:

brew install simonw/datasette/datasette

See https://github.com/simonw/homebrew-datasette for details.

@simonw
Copy link
Copy Markdown
Contributor Author

simonw commented Aug 12, 2020

Here's the output of brew test datasette:

% brew test datasette
==> Testing simonw/datasette/datasette
==> /usr/local/Cellar/datasette/0.47.1/bin/datasette --get '/:memory:.csv?sql=select+3*5'
==> /usr/local/Cellar/datasette/0.47.1/bin/datasette --get '/'

Datasette usually runs as a localhost web server, but I added a feature where running --get /path simulates running a request through the the server and outputs the HTTP response to standard-out. This was useful for building the tests for Homebrew but is also a great feature for the software to have generally: https://datasette.readthedocs.io/en/stable/getting_started.html#datasette-get

@BrewTestBot BrewTestBot added missing license Formula has a missing license which should be added new formula PR adds a new formula to Homebrew/homebrew-core python Python use is a significant feature of the PR or issue labels Aug 12, 2020
@dawidd6 dawidd6 removed the missing license Formula has a missing license which should be added label Aug 12, 2020
@dawidd6
Copy link
Copy Markdown
Contributor

dawidd6 commented Aug 12, 2020

Please squash your commits.

@simonw
Copy link
Copy Markdown
Contributor Author

simonw commented Aug 12, 2020

I was hoping this commit could be landed using the "squash merge" option, but I can squash the commits and force push to the branch instead if that's the Homebrew preferred way.

@simonw
Copy link
Copy Markdown
Contributor Author

simonw commented Aug 12, 2020

(For my own notes) I ran this:

git rebase -i HEAD~2

Then typed s next to the license commit. This merged the two into one. Then I ran this:

git push --force

@BrewTestBot
Copy link
Copy Markdown
Contributor

:shipit: @dawidd6 has triggered a merge.

@simonw
Copy link
Copy Markdown
Contributor Author

simonw commented Aug 12, 2020

Thanks @dawidd6!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new formula PR adds a new formula to Homebrew/homebrew-core python Python use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants