Skip to content

pango: fix the build on newer clang releases#58853

Closed
mistydemeo wants to merge 2 commits intoHomebrew:masterfrom
mistydemeo:pango_fix_newer_clang
Closed

pango: fix the build on newer clang releases#58853
mistydemeo wants to merge 2 commits intoHomebrew:masterfrom
mistydemeo:pango_fix_newer_clang

Conversation

@mistydemeo
Copy link
Copy Markdown
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

This fixes the build on upcoming versions of clang, which are stricter about fallthrough in switch statements. Thankfully the appropriate fix is already applied upstream; we just need to apply it. This requires backporting an additional upstream patch for glib in order to ensure the appropriate macro is defined.

@mistydemeo mistydemeo added the 11 Big Sur is specifically affected label Jul 30, 2020
@BrewTestBot BrewTestBot added the missing license Formula has a missing license which should be added label Jul 31, 2020
@dawidd6 dawidd6 removed the missing license Formula has a missing license which should be added label Jul 31, 2020
@BrewTestBot
Copy link
Copy Markdown
Contributor

🤖 A scheduled task has triggered a merge.

@mistydemeo mistydemeo deleted the pango_fix_newer_clang branch August 1, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

11 Big Sur is specifically affected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants