pango: fix the build on newer clang releases#58853
Closed
mistydemeo wants to merge 2 commits intoHomebrew:masterfrom
Closed
pango: fix the build on newer clang releases#58853mistydemeo wants to merge 2 commits intoHomebrew:masterfrom
mistydemeo wants to merge 2 commits intoHomebrew:masterfrom
Conversation
9 tasks
SeekingMeaning
approved these changes
Aug 1, 2020
Contributor
|
🤖 A scheduled task has triggered a merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?This fixes the build on upcoming versions of clang, which are stricter about fallthrough in
switchstatements. Thankfully the appropriate fix is already applied upstream; we just need to apply it. This requires backporting an additional upstream patch forglibin order to ensure the appropriate macro is defined.