Skip to content

aom: fix build on Apple Silicon#57976

Closed
mistydemeo wants to merge 1 commit intoHomebrew:masterfrom
mistydemeo:aom_fix_apple_silicon
Closed

aom: fix build on Apple Silicon#57976
mistydemeo wants to merge 1 commit intoHomebrew:masterfrom
mistydemeo:aom_fix_apple_silicon

Conversation

@mistydemeo
Copy link
Copy Markdown
Contributor

@mistydemeo mistydemeo commented Jul 15, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

AOM currently doesn't have runtime CPU detection for ARM on macOS. This leads to the following compiletime error:

/usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang  -I/tmp/aom-20200714-71065-13zya5m -I/tmp/aom-20200714-71065-13zya5m/macbuild -I/tmp/aom-20200714-71065-13zya5m/apps -I/tmp/aom-20200714-71065-13zya5m/common -I/tmp/aom-20200714-71065-13zya5m/examples -I/tmp/aom-20200714-71065-13zya5m/stats -I/tmp/aom-20200714-71065-13zya5m/third_party/libyuv/include -I/tmp/aom-20200714-71065-13zya5m/third_party/libwebm  -fno-stack-check -DNDEBUG -std=c99 -Wall -Wdisabled-optimization -Wextra -Wfloat-conversion -Wimplicit-function-declaration -Wlogical-op -Wpointer-arith -Wshorten-64-to-32 -Wsign-compare -Wstring-conversion -Wtype-limits -Wuninitialized -Wunused -Wvla -Wstack-usage=100000 -Wshadow -Wundef -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -isysroot /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk   -o CMakeFiles/aom_encoder_app_util.dir/common/ivfenc.c.o   -c /tmp/aom-20200714-71065-13zya5m/common/ivfenc.c
/tmp/aom-20200714-71065-13zya5m/aom_ports/arm_cpudetect.c:147:2: error: "--enable-runtime-cpu-detect selected, but no CPU detection method " "available for your platform. Reconfigure with --disable-runtime-cpu-detect."
#error \
 ^
1 error generated.

As noted by that message, we can disable runtime CPU detection and it will build and run properly. I've left runtime CPU detection on for all other platforms, since it works there. In the future, AOM will likely gain runtime CPU detection on macOS and we'll be able to remove this at some point.

@mistydemeo mistydemeo force-pushed the aom_fix_apple_silicon branch from 602a7ab to 3b09522 Compare July 15, 2020 00:59
@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented Jul 15, 2020

🤖 A scheduled task has triggered a merge.

@mistydemeo mistydemeo deleted the aom_fix_apple_silicon branch July 15, 2020 03:13
@claui claui added the 11 Big Sur is specifically affected label Jul 19, 2020
@claui claui mentioned this pull request Jul 19, 2020
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@claui claui claui approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

11 Big Sur is specifically affected

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mistydemeo @BrewTestBot @claui