pcre2: Only enabled JIT on x86_64 as workaround to ARM crash.#57419
Merged
claui merged 1 commit intoHomebrew:masterfrom Jul 4, 2020
DodgyTim:pcre2_arm_workaround
Merged
pcre2: Only enabled JIT on x86_64 as workaround to ARM crash.#57419claui merged 1 commit intoHomebrew:masterfrom DodgyTim:pcre2_arm_workaround
claui merged 1 commit intoHomebrew:masterfrom
DodgyTim:pcre2_arm_workaround
Conversation
9 tasks
Contributor
|
The 10.14 CI failure is spurious and can be ignored. Edit: Same for 10.15 and 10.13. Edit 2: Double-checked and confirmed that it’s just Homebrew/brew#7667 again. |
claui
approved these changes
Jul 4, 2020
Contributor
claui
left a comment
There was a problem hiding this comment.
Confirming that this works, and fixes brew test pcre2 on arm64.
Contributor
|
are there any more details on that crash that could be provided to resolve zherczeg/sljit#51? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?The JIT implementation in pcre2 crashes during test on Big Sur / ARM. This change restricts the JIT functionality to x86_64 for now, allowing the formula to work successfully on ARM.
Tested on both architectures. I have filed a similar PR for pcre.