Skip to content

perkeep: depend on go@1.10#52131

Closed
Bo98 wants to merge 1 commit into
Homebrew:masterfrom
Bo98:perkeep
Closed

perkeep: depend on go@1.10#52131
Bo98 wants to merge 1 commit into
Homebrew:masterfrom
Bo98:perkeep

Conversation

@Bo98

@Bo98 Bo98 commented Mar 25, 2020

Copy link
Copy Markdown
Member
  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Also exclude moving .brew_home, so we get better errors.

You're using go1.14 != go1.10, which GopherJS requires, and it was not found in /private/tmp/perkeep-20200325-3472-1e6w9i3/.brew_home. You need to specify a go1.10 root in CAMLI_GOPHERJS_GOROOT for building GopherJS.

@SMillerDev

SMillerDev commented Mar 25, 2020

Copy link
Copy Markdown
Member

Each major Go release is supported until there are two newer major releases

https://golang.org/doc/devel/release.html#policy

We should remove 1.10, 1.11, 1.12 and all formula that depend on it should be dropped from core for being unable to support the current state of the art.

@Bo98

Bo98 commented Mar 25, 2020

Copy link
Copy Markdown
Member Author

Fair point. It seems like we've never removed a versioned Go before.

@Bo98

Bo98 commented Mar 25, 2020

Copy link
Copy Markdown
Member Author

Looks like we're over the 5 limit as well.

@SMillerDev

SMillerDev commented Mar 25, 2020

Copy link
Copy Markdown
Member

Looks like we're over the 5 limit as well.

You might know this better then me, is that auditable?

@Bo98

Bo98 commented Mar 25, 2020

Copy link
Copy Markdown
Member Author

I'd say yes.

@Bo98 Bo98 closed this Mar 25, 2020
@Bo98 Bo98 deleted the perkeep branch March 25, 2020 21:42
@jonchang jonchang mentioned this pull request Mar 25, 2020
Closed
5 tasks
@lock lock Bot added the outdated PR was locked due to age label Apr 25, 2020
@lock lock Bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Bo98 @SMillerDev