nushell: update to 0.7.0 and add stable features#48041
nushell: update to 0.7.0 and add stable features#48041waldyrious wants to merge 2 commits intoHomebrew:masterfrom
Conversation
This feature cannot be activated dynamically; it needs to enabled at compilation time.
|
def install
system "cargo", "install",
*("--features starship-prompt" if build.with? "starship"),
"--locked",
"--root", prefix,
"--path", "."
end
Edit: I fixed the test to match the output with the stable features enabled, which include the starship prompt. |
|
I am also wondering if we should default to the stable features instead of singling out the starship prompt feature (which is included in the stable features set). However, I was unable to get it to work with a similar syntax to the one currently in this PR (i.e. def install
- system "cargo", "install", "--locked", "--root", prefix, "--path", "."
+ system "cargo", "install", "--features", "stable", "--locked", "--root", prefix, "--path", "."
endAny thoughts about whether this is a better approach, and if so, how to make it work? |
|
Ah, I just now read the release notes for 0.7.0. Turns out the stable features set is a new addition, so it should be available if we update the version in this PR. I'll do so tomorrow. |
|
PR now updated to perform the 0.7.0 update as well as enable the stable features during build. |
|
@BrewTestBot test this please. |
|
lgtm, thanks @waldyrious!! |
This PR was originally created to add support for the starship prompt feature, but soon after creating it I realized that 0.7.0 had been released, so I updated the PR to upgrade the formula and enable the stable features (which include the starship prompt).
/cc @chenrui333 who has been involved in previous Nushell PRs.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?