Skip to content

virtuoso: patches for OpenSSL 1.1#46885

Closed
Bo98 wants to merge 1 commit intoHomebrew:masterfrom
Bo98:virtuoso
Closed

virtuoso: patches for OpenSSL 1.1#46885
Bo98 wants to merge 1 commit intoHomebrew:masterfrom
Bo98:virtuoso

Conversation

@Bo98
Copy link
Copy Markdown
Member

@Bo98 Bo98 commented Nov 18, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

This pull request removes --HEAD support for now as the patches are incompatible (but still required in part).

@Bo98 Bo98 mentioned this pull request Nov 18, 2019
Merged
chenrui333
chenrui333 approved these changes Nov 19, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@fxcoudert fxcoudert closed this in 3386e02 Nov 19, 2019
@Bo98 Bo98 deleted the virtuoso branch November 19, 2019 10:21
@lock lock bot added the outdated PR was locked due to age label Jan 2, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees

No one assigned

Labels

outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Bo98 @chenrui333