WIP: Initial dotnet formula#3691
Conversation
|
Currently failing to build unless the latest openssl binaries are used with Then failing with: Which I suppose is because it places stuff in a special folder. What's the incantation to tell it to fetch all things from |
3220888 to
6a26099
Compare
|
Ref https://github.com/dotnet/cli/issues/3964#issuecomment-236832511 Added two TODOs I need help with. |
There was a problem hiding this comment.
this doesn't need to run as root
There was a problem hiding this comment.
Can you please submit this patch to the upstream developers of this project and add a link to the upstream patch submission and explanation of why the patch is needed in a comment in the formula file. Thanks!
There was a problem hiding this comment.
It's because they require git to build... How do you normally deal with that?
b3bd54e to
cb137c9
Compare
|
@dunn Excellent, thanks for that hint. So then it's only this TODO left before this may even work in some manner: |
Sorry, I'm not sure what you mean. Which folders, and what needs to be done to them? |
|
@dunn Normally it would output stuff to |
|
Compile steps should always leave the build product in the temporary directory TL;DR nothing is ever automatically installed into |
|
@dunn is this what you're thinking of? |
There was a problem hiding this comment.
This might need to be prefix.install Dir["#{buildpath}/artifacts/osx.#{MacOS.version}-x64/stage2/*"], but if everything other than the dotnet binary belongs in the root prefix (as opposed to lib, libexec, etc.) then yeah, this is the right approach.
|
The current state, when moving Because it's looking to a sibling folder, but not finding it. Instead prefix.install Dir["#{stage2}/*"]And nothing else makes it work as intended. I'm not much into how native dylibs load, so perhaps someone could enlighten me as to how it would work with I'm going to fix the git checkout like @MikeMcQuaid wanted, but this PR is starting to get ready besides this particular change request. |
|
In summary: how do I make the dylibs/loading work when the |
|
I'll look at this more closely when I can, but if installing the libraries directly into |
Agreed as long as
You probably need to ask upstream that question as it's not really a Homebrew one. |
|
@MikeMcQuaid I'm really just asking for a link to where I can understand how the loading works on OS X with binary vs dependent library; not particularly asking for netcore. |
|
Please tell me what you want changed by pointing me in the direction of the documentation that documents the APIs you want to use. You say git reference; where are those docs? |
|
Passing on this until we have a stable version that builds without patching and passes |
|
Wow. What a dude you are Mike. |
|
@haf We're doing our best to run this project effectively. |
|
@MikeMcQuaid I ask for help, you close the issue. And the lint has been passing many times over and its version is RTM, so you should not close it. You should focus on running the project productively instead, and that means taking into account lead times on change requests you make of me. If you think I've dropped this PR, then you're mistaken. |
|
A list of what needs addressed before we can include this:
|
|
wrt dynamic linkage discovery, you're probably looking the bottom of |
I'm looking forward to continuing this PR when it's open again. |
|
@haf did you find a workaround for the openssl-formula-must-be-linked problem? |
|
@ilovezfs Yes, that's now part of the PR and works really nicely! |
|
/cc @blackdwarf for feedback/help about this pr |
|
@BrewTestBot test this please |
|
I reopened this 10 days ago and there's been no movement since then and CI is failing in a way that's trivially reproducible by running To preempt some responses:
|
brew install <formula>(where<formula>is the name of the formula you're submitting)?brew audit --strict --online <formula>(after doingbrew install <formula>)?Ref https://github.com/dotnet/cli/issues/533
Unfortunately MSFT is a bit new on the OSS scene so they release 1.0 RTM tagged as
preview2on github, which is why this formula is not in fact a pre-release formula.The original pkg file installs like this:
In
/usr/local/share/dotnet/that is. TODO: not sure how to copy thestage2folder to this location, or the Cellar location of the formula.