Skip to content

streamlink: fix test on linux#246141

Merged
branchv merged 1 commit intoHomebrew:mainfrom
branchv:streamlink
Oct 1, 2025
Merged

streamlink: fix test on linux#246141
branchv merged 1 commit intoHomebrew:mainfrom
branchv:streamlink

Conversation

@branchv
Copy link
Member

@branchv branchv commented Sep 29, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Fix for linux failure in #245931

Expected /Could not get video info - LOGIN_REQUIRED|plugin does not support VOD content/ to match "...This video may be protected.\nerror: This plugin does not support protected videos, try yt-dlp instead\n".

@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Sep 29, 2025
@branchv branchv added CI-no-bottles Merge without publishing bottles python Python use is a significant feature of the PR or issue and removed python Python use is a significant feature of the PR or issue labels Sep 29, 2025
@branchv branchv added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Sep 29, 2025
@branchv branchv marked this pull request as draft September 29, 2025 15:43
@branchv branchv added the CI-linux-self-hosted Build on Linux self-hosted runner label Sep 29, 2025
@branchv branchv removed the CI-linux-self-hosted Build on Linux self-hosted runner label Oct 1, 2025
@branchv branchv marked this pull request as ready for review October 1, 2025 01:28
@branchv
Copy link
Member Author

branchv commented Oct 1, 2025

It looks like ok.ru used to be blocked by our linux runner which is why we tested different url's for mac/linux (see #119487), but that is not longer the case. So let's use the same one now.

If this fails again on linux, we should just skip it since the test was added in 7947910 to catch an issue on macos issue anyway

@branchv branchv added the ready to merge PR can be merged once CI is green label Oct 1, 2025
@branchv branchv enabled auto-merge October 1, 2025 01:30
@branchv branchv requested a review from chenrui333 October 1, 2025 04:17
@branchv branchv added this pull request to the merge queue Oct 1, 2025
Merged via the queue into Homebrew:main with commit 478cdc3 Oct 1, 2025
57 of 64 checks passed
@branchv branchv deleted the streamlink branch October 1, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. python Python use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants