Skip to content

python-build: build an :all bottle#191251

Merged
BrewTestBot merged 2 commits into
masterfrom
python-build-all
Sep 19, 2024
Merged

python-build: build an :all bottle#191251
BrewTestBot merged 2 commits into
masterfrom
python-build-all

Conversation

@carlocab

@carlocab carlocab commented Sep 19, 2024

Copy link
Copy Markdown
Member
  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

There's a stray /usr/local in a code comment. Let's just replace that
with HOMEBREW_PREFIX so our bottles are the same across os versions.

@carlocab
python-build: build an :all bottle
ee236cf 
There's a stray `/usr/local` in a code comment. Let's just replace that
with `HOMEBREW_PREFIX` so our bottles are the same across os versions.
@github-actions github-actions Bot added the python Python use is a significant feature of the PR or issue label Sep 19, 2024
@carlocab

carlocab commented Sep 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Checksums match ✅

3af731d79dae765ec4189d4b411ef8f86b20fe27ff997e99a2870a156459beab
3af731d79dae765ec4189d4b411ef8f86b20fe27ff997e99a2870a156459beab
3af731d79dae765ec4189d4b411ef8f86b20fe27ff997e99a2870a156459beab
3af731d79dae765ec4189d4b411ef8f86b20fe27ff997e99a2870a156459beab
3af731d79dae765ec4189d4b411ef8f86b20fe27ff997e99a2870a156459beab
3af731d79dae765ec4189d4b411ef8f86b20fe27ff997e99a2870a156459beab

@carlocab carlocab marked this pull request as ready for review September 19, 2024 18:36
@carlocab carlocab added the ready to merge PR can be merged once CI is green label Sep 19, 2024
p-linnane
p-linnane approved these changes Sep 19, 2024
View reviewed changes

@p-linnane p-linnane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@github-actions

github-actions Bot commented Sep 19, 2024

Copy link
Copy Markdown
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions Bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 19, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 19, 2024
Merged via the queue into master with commit 0612b2e Sep 19, 2024
@BrewTestBot BrewTestBot deleted the python-build-all branch September 19, 2024 18:50
@carlocab carlocab mentioned this pull request Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@p-linnane p-linnane p-linnane approved these changes

Assignees

No one assigned

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. python Python use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlocab @p-linnane @BrewTestBot