Skip to content

apache-arrow-glib apache-arrow 15.0.2#166595

Merged
BrewTestBot merged 4 commits intomasterfrom
apache-arrow-apache-arrow-glib-15.0.2
Mar 24, 2024
Merged

apache-arrow-glib apache-arrow 15.0.2#166595
BrewTestBot merged 4 commits intomasterfrom
apache-arrow-apache-arrow-glib-15.0.2

Conversation

@chenrui333
Copy link
Copy Markdown
Member

@chenrui333 chenrui333 commented Mar 19, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@chenrui333
Copy link
Copy Markdown
Member Author

chenrui333 commented Mar 19, 2024 

[16/101] clang++ -Iarrow-glib/libarrow-glib.1500.dylib.p -I. -I../c_glib -I/opt/homebrew/Cellar/brotli/1.1.0/include -I/opt/homebrew/Cellar/lz4/1.9.4/include -I/opt/homebrew/Cellar/zstd/1.5.5/include -I/opt/homebrew/Cellar/utf8proc/2.9.0/include -I/opt/homebrew/Cellar/apache-arrow/15.0.2/include -I/opt/homebrew/Cellar/pcre2/10.43/include -I/opt/homebrew/Cellar/glib/2.80.0/include -I/opt/homebrew/Cellar/glib/2.80.0/include/glib-2.0 -I/opt/homebrew/Cellar/glib/2.80.0/lib/glib-2.0/include -I/opt/homebrew/opt/gettext/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/include/ffi -fdiagnostics-color=always -Wall -Winvalid-pch -std=c++17 -O3 -Wmissing-declarations -Wno-incompatible-function-pointer-types -DUTF8PROC_EXPORTS -MD -MQ arrow-glib/libarrow-glib.1500.dylib.p/composite-array.cpp.o -MF arrow-glib/libarrow-glib.1500.dylib.p/composite-array.cpp.o.d -o arrow-glib/libarrow-glib.1500.dylib.p/composite-array.cpp.o -c ../c_glib/arrow-glib/composite-array.cpp
FAILED: arrow-glib/libarrow-glib.1500.dylib.p/composite-array.cpp.o
clang++ -Iarrow-glib/libarrow-glib.1500.dylib.p -I. -I../c_glib -I/opt/homebrew/Cellar/brotli/1.1.0/include -I/opt/homebrew/Cellar/lz4/1.9.4/include -I/opt/homebrew/Cellar/zstd/1.5.5/include -I/opt/homebrew/Cellar/utf8proc/2.9.0/include -I/opt/homebrew/Cellar/apache-arrow/15.0.2/include -I/opt/homebrew/Cellar/pcre2/10.43/include -I/opt/homebrew/Cellar/glib/2.80.0/include -I/opt/homebrew/Cellar/glib/2.80.0/include/glib-2.0 -I/opt/homebrew/Cellar/glib/2.80.0/lib/glib-2.0/include -I/opt/homebrew/opt/gettext/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/include/ffi -fdiagnostics-color=always -Wall -Winvalid-pch -std=c++17 -O3 -Wmissing-declarations -Wno-incompatible-function-pointer-types -DUTF8PROC_EXPORTS -MD -MQ arrow-glib/libarrow-glib.1500.dylib.p/composite-array.cpp.o -MF arrow-glib/libarrow-glib.1500.dylib.p/composite-array.cpp.o.d -o arrow-glib/libarrow-glib.1500.dylib.p/composite-array.cpp.o -c ../c_glib/arrow-glib/composite-array.cpp
../c_glib/arrow-glib/composite-array.cpp:613:10: error: cannot initialize return object of type 'const gint64 *' (aka 'const long *') with an rvalue of type 'const typename LargeListArray::offset_type *' (aka 'const long long *')
  return garrow_base_list_array_get_value_offsets<arrow::LargeListArray>(
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

@chenrui333 chenrui333 added the build failure CI fails while building the software label Mar 19, 2024
@chenrui333 chenrui333 mentioned this pull request Mar 19, 2024
Closed
@chenrui333 chenrui333 added the upstream issue An upstream issue report is needed label Mar 20, 2024
@cho-m
Copy link
Copy Markdown
Member

cho-m commented Mar 21, 2024 •
edited
Loading

This may actually partly be a Homebrew bug. Similar odd gint64 type change seen in a number of other GNOME formulae.

Trying to dig into this further. I think our ENV.refurbish_args is the culprit being called inside virtualenv_create and causing problems for glib. Will try some things locally and probably revision bump glib with fix.

EDIT: Though officially, it is documented that the types should not be assumed to be identical - https://docs.gtk.org/glib/types.html#gint64.

Note that on platforms with more than one 64-bit standard integer type, gint64 and int64_t are not necessarily implemented by the same 64-bit integer type. For example, on a platform where both long and long long are 64-bit, it might be the case that one of those types is used for gint64 and the other is used for int64_t.

So if upstream code does assume this, it is probably a good idea to handle above scenario, which is current state of our bottled glib.

@cho-m cho-m added blocked and removed upstream issue An upstream issue report is needed blocked labels Mar 22, 2024
@cho-m cho-m force-pushed the apache-arrow-apache-arrow-glib-15.0.2 branch from 2571b41 to 653a1bb Compare March 22, 2024 21:49
@cho-m cho-m removed the build failure CI fails while building the software label Mar 23, 2024
@chenrui333 @cho-m
apache-arrow-glib 15.0.2
e88bfb7 
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Michael Cho <michael@michaelcho.dev>
@chenrui333 @cho-m
apache-arrow 15.0.2
7031495 
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Michael Cho <michael@michaelcho.dev>
@cho-m cho-m force-pushed the apache-arrow-apache-arrow-glib-15.0.2 branch from 653a1bb to 7031495 Compare March 23, 2024 16:53
@cho-m cho-m added the ready to merge PR can be merged once CI is green label Mar 23, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 24, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Mar 24, 2024
@BrewTestBot BrewTestBot enabled auto-merge March 24, 2024 03:51
@BrewTestBot BrewTestBot added this pull request to the merge queue Mar 24, 2024
Merged via the queue into master with commit 2343c16 Mar 24, 2024
@BrewTestBot BrewTestBot deleted the apache-arrow-apache-arrow-glib-15.0.2 branch March 24, 2024 03:57
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@branchv branchv branchv approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

No one assigned

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age ready to merge PR can be merged once CI is green

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chenrui333 @cho-m @branchv @BrewTestBot