Skip to content

arangodb 3.11.1#135487

Closed
cho-m wants to merge 1 commit into
Homebrew:masterfrom
cho-m:bump-arangodb-3.11.1
Closed

arangodb 3.11.1#135487
cho-m wants to merge 1 commit into
Homebrew:masterfrom
cho-m:bump-arangodb-3.11.1

Conversation

@cho-m

@cho-m cho-m commented Jul 1, 2023

Copy link
Copy Markdown
Member
  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Trying some things out...

@github-actions github-actions Bot added go Go use is a significant feature of the PR or issue long build Set a long timeout for formula testing labels Jul 1, 2023
@cho-m cho-m added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jul 1, 2023
@cho-m cho-m marked this pull request as draft July 1, 2023 03:01
@cho-m

cho-m commented Jul 1, 2023

Copy link
Copy Markdown
Member Author

Sadly no idea if there is way to workaround current failure:

  /tmp/arangodb-20230630-89543-1vkojor/ArangoDB-3.11.1/lib/Inspection/include/Inspection/Access.h:52:3: error: static assertion failed due to requirement 'detail::IsInspectable()'
    static_assert(detail::IsInspectable<TT, Inspector>());
    ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I'll experiment with downgrading LLVM and/or switching to GCC. Upstream has stated they will not support compiler versions outside of https://github.com/arangodb/arangodb/blob/v3.11.1/VERSIONS

Afterward, we can decide whether to go this route or to deprecate.

@github-actions github-actions Bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jul 1, 2023
@carlocab carlocab added the openssl-3-migration Related to switching to an OpenSSL 3 dependency label Jul 1, 2023
@Bo98

Bo98 commented Jul 1, 2023

Copy link
Copy Markdown
Member

Upstream has stated they will not support compiler versions outside of https://github.com/arangodb/arangodb/blob/v3.11.1/VERSIONS

Thing is that it fails across all macOS versions. Using LLVM 12, 14 and 15 based compilers. It's tricky to track down why but I'll see if I can see anything.

Linux error is however caused by us using GCC 10 here, which is too old. We should try 11 again.

@cho-m

cho-m commented Jul 1, 2023

Copy link
Copy Markdown
Member Author

Thing is that it fails across all macOS versions. Using LLVM 12, 14 and 15 based compilers. It's tricky to track down why but I'll see if I can see anything.

We are using brewed llvm so LLVM 16. In addition to original reason, upstream has added a version checker that will reject AppleClang (https://github.com/arangodb/arangodb/blob/v3.11.1/cmake/CheckCompilerVersion.cmake)

EDIT: Rather than reject, the logic just doesn't work as MIN_VERSION isn't set.

CMake Warning at cmake/CheckCompilerVersion.cmake:18 (message):
  AppleClang/AppleClang compiler is not supported.
Call Stack (most recent call first):
  CMakeLists.txt:496 (CheckCompilerVersion)


CMake Error at cmake/CheckCompilerVersion.cmake:21 (if):
  if given arguments:

    "(" "CMAKE_C_COMPILER_VERSION" "VERSION_LESS" ")" "OR" "(" "CMAKE_CXX_COMPILER_VERSION" "VERSION_LESS" ")"

  Unknown arguments specified
Call Stack (most recent call first):
  CMakeLists.txt:496 (CheckCompilerVersion)


-- Configuring incomplete, errors occurred!

Linux error is however caused by us using GCC 10 here, which is too old. We should try 11 again.

Yeah. Looks like minimum GCC 11.1 is needed for std::atomic<T>::wait. Will try default GCC 11.3 again, but may need to apply workaround patch if it hits bug.

@Bo98

Bo98 commented Jul 1, 2023

Copy link
Copy Markdown
Member

Thing is that it fails across all macOS versions. Using LLVM 12, 14 and 15 based compilers. It's tricky to track down why but I'll see if I can see anything.

We are using brewed llvm so LLVM 16. In addition to original reason, upstream has added a version checker that will reject AppleClang (https://github.com/arangodb/arangodb/blob/v3.11.1/cmake/CheckCompilerVersion.cmake)

Oh oops misread that.

The script you link technically outputs warnings rather than fails though. But yeah might need to use an older LLVM if Apple Clang doesn't work. Ah I see what you're referring to now - technically a bug really where it should be using elseif.

@cho-m cho-m force-pushed the bump-arangodb-3.11.1 branch from 52c2cfe to 037bc3c Compare July 1, 2023 17:28
@cho-m cho-m added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jul 1, 2023
@carlocab

carlocab commented Jul 1, 2023

Copy link
Copy Markdown
Member

We should probably just deprecate this formula TBH. It had ~500 downloads in the past month (numbers based on GitHub Packages). I don't think that's worth the amount of CI/maintainer time this formula takes up. (Unless there actually is a maintainer that uses this formula and is willing to work on it.) I'm pretty sure it vendors all sorts of dependencies too.

CC @Homebrew/core for thoughts.

@cho-m

cho-m commented Jul 1, 2023

Copy link
Copy Markdown
Member Author

We should probably just deprecate this formula TBH.

That is fine with me. Upstream also sounds like they want us to deprecate/remove it as their response to any build issues is to install their version.

I'm pretty sure it vendors all sorts of dependencies too.

Yeah, it does https://github.com/arangodb/arangodb/tree/devel/3rdParty which is part of reason build fails (V8 and Boost copies have issues with LLVM 16).

@p-linnane

Copy link
Copy Markdown
Member

Agreed with deprecating it.

@github-actions github-actions Bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jul 1, 2023
@MikeMcQuaid

Copy link
Copy Markdown
Member

Agreed on deprecation 👍🏻

@p-linnane p-linnane mentioned this pull request Jul 6, 2023
@p-linnane

Copy link
Copy Markdown
Member

Opened #135907 to deprecate.

@cho-m cho-m deleted the bump-arangodb-3.11.1 branch October 30, 2023 22:38
@github-actions github-actions Bot added the outdated PR was locked due to age label Nov 30, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. go Go use is a significant feature of the PR or issue long build Set a long timeout for formula testing openssl-3-migration Related to switching to an OpenSSL 3 dependency outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants