Skip to content

rizin: actually use openssl@3 on Linux#134923

Merged
BrewTestBot merged 2 commits into
Homebrew:openssl-migration-stagingfrom
nandahkrishna:rizin-openssl
Jun 25, 2023
Merged

rizin: actually use openssl@3 on Linux#134923
BrewTestBot merged 2 commits into
Homebrew:openssl-migration-stagingfrom
nandahkrishna:rizin-openssl

Conversation

@nandahkrishna

@nandahkrishna nandahkrishna commented Jun 25, 2023

Copy link
Copy Markdown
Member

See #134251. rizin has linkage with openssl@1.1 on Linux but not macOS -- openssl@1.1 was an indirect dependency on Linux alone via libzip.

linuxbrew@8fda9e96befe:~$ brew linkage -v rizin
...
Homebrew libraries:
  ...
  /home/linuxbrew/.linuxbrew/opt/openssl@1.1/lib/libcrypto.so.1.1 (openssl@1.1)
  /home/linuxbrew/.linuxbrew/opt/openssl@1.1/lib/libssl.so.1.1 (openssl@1.1)
  ...
Indirect dependencies with linkage:
  openssl@1.1

Now that libzip has switched to openssl@3, a revision bump should hopefully fix things here.

@nandahkrishna nandahkrishna added openssl-3-migration Related to switching to an OpenSSL 3 dependency staging-branch-pr This pull request targets a *-staging branch. labels Jun 25, 2023
@nandahkrishna nandahkrishna mentioned this pull request Jun 25, 2023
Closed
@nandahkrishna

nandahkrishna commented Jun 25, 2023

Copy link
Copy Markdown
Member Author

Linux:

==> brew linkage --cached rizin
...
Homebrew libraries:
  ...
  /home/linuxbrew/.linuxbrew/opt/openssl@3/lib/libcrypto.so.3 (openssl@3)
  /home/linuxbrew/.linuxbrew/opt/openssl@3/lib/libssl.so.3 (openssl@3)
  ...

@nandahkrishna nandahkrishna added the ready to merge PR can be merged once CI is green label Jun 25, 2023
@github-actions

github-actions Bot commented Jun 25, 2023

Copy link
Copy Markdown
Contributor

:shipit: @carlocab has requested bottles to be published to this PR.

@github-actions github-actions Bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jun 25, 2023
@BrewTestBot BrewTestBot enabled auto-merge June 25, 2023 06:45
@BrewTestBot BrewTestBot merged commit 446b76d into Homebrew:openssl-migration-staging Jun 25, 2023
@nandahkrishna nandahkrishna deleted the rizin-openssl branch June 25, 2023 07:10
@github-actions github-actions Bot added the outdated PR was locked due to age label Jul 26, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@carlocab carlocab carlocab approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

No one assigned

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. openssl-3-migration Related to switching to an OpenSSL 3 dependency outdated PR was locked due to age ready to merge PR can be merged once CI is green staging-branch-pr This pull request targets a *-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nandahkrishna @carlocab @BrewTestBot