Skip to content

hadoop: switch to openssl@3 (linkage test)#134914

Closed
chenrui333 wants to merge 1 commit into
Homebrew:masterfrom
chenrui333:hadoop-openssl3
Closed

hadoop: switch to openssl@3 (linkage test)#134914
chenrui333 wants to merge 1 commit into
Homebrew:masterfrom
chenrui333:hadoop-openssl3

Conversation

@chenrui333

Copy link
Copy Markdown
Member

See #134251.

@chenrui333 chenrui333 added openssl-3-migration Related to switching to an OpenSSL 3 dependency staging-branch-pr This pull request targets a *-staging branch. labels Jun 24, 2023
@github-actions github-actions Bot added the java Java use is a significant feature of the PR or issue label Jun 24, 2023
@Bo98

Bo98 commented Jun 26, 2023

Copy link
Copy Markdown
Member

We're installing prebuilts here, hence the linkage failure.

The real source archive has a -src, and will require rewriting the rest of the formula.

Signed-off-by: Rui Chen <rui@chenrui.dev>
@p-linnane p-linnane changed the base branch from openssl-migration-staging to master June 26, 2023 23:47
@p-linnane p-linnane removed the staging-branch-pr This pull request targets a *-staging branch. label Jun 26, 2023
@cho-m

cho-m commented Jun 27, 2023

Copy link
Copy Markdown
Member

I think the problem of switching to source build is we need to use openjdk@8 which also requires dropping ARM support. Upstream openjdk@11 build issue is still open https://issues.apache.org/jira/browse/HADOOP-16795

On macOS, I don't think there are any compiled libs/bins (ignoring anything that may be packaged inside JARs).

On Linux, there are a couple. Part of reason we don't ship the native libraries (lib/).

@cho-m

cho-m commented Jul 4, 2023

Copy link
Copy Markdown
Member

I removed the particular Linux-specific prebuilts in #135709 so should be fine for now (i.e. no more linkage to OpenSSL). If someone wants, they can try out source build, but I am not sure on switching to source build unless it supports openjdk@11 (or openjdk@8 works on Apple Silicon).

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions Bot added the stale No recent activity label Jul 26, 2023
@github-actions github-actions Bot closed this Aug 2, 2023
@github-actions github-actions Bot added the outdated PR was locked due to age label Sep 1, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 1, 2023
@chenrui333 chenrui333 deleted the hadoop-openssl3 branch January 22, 2024 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

java Java use is a significant feature of the PR or issue openssl-3-migration Related to switching to an OpenSSL 3 dependency outdated PR was locked due to age stale No recent activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants