Skip to content

wdc: mark openssl as build dep#134850

Merged
p-linnane merged 1 commit into
Homebrew:openssl-migration-stagingfrom
chenrui333:wdc-openssl3
Jun 25, 2023
Merged

wdc: mark openssl as build dep#134850
p-linnane merged 1 commit into
Homebrew:openssl-migration-stagingfrom
chenrui333:wdc-openssl3

Conversation

@chenrui333

@chenrui333 chenrui333 commented Jun 24, 2023

Copy link
Copy Markdown
Member

See #134251.

@chenrui333 chenrui333 added openssl-3-migration Related to switching to an OpenSSL 3 dependency staging-branch-pr This pull request targets a *-staging branch. labels Jun 24, 2023
@chenrui333 chenrui333 mentioned this pull request Jun 24, 2023
Closed
@github-actions github-actions Bot added missing license Formula has a missing license which should be added boost Boost use is a significant feature of the PR or issue labels Jun 24, 2023
@chenrui333 chenrui333 changed the title wdc: switch to openssl@3 wdc: remove openssl dep Jun 24, 2023
@chenrui333 chenrui333 added the CI-no-bottles Merge without publishing bottles label Jun 24, 2023
@chenrui333

chenrui333 commented Jun 24, 2023

Copy link
Copy Markdown
Member Author 
CMake Error at /opt/homebrew/Cellar/cmake/3.26.4/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
    Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the
    system variable OPENSSL_ROOT_DIR (missing: OPENSSL_CRYPTO_LIBRARY
    OPENSSL_INCLUDE_DIR)
  Call Stack (most recent call first):
    /opt/homebrew/Cellar/cmake/3.26.4/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:[60](https://github.com/Homebrew/homebrew-core/actions/runs/5362614156/jobs/9729660418?pr=134850#step:3:61)0 (_FPHSA_FAILURE_MESSAGE)
    /opt/homebrew/Cellar/cmake/3.26.4/share/cmake/Modules/FindOpenSSL.cmake:670 (find_package_handle_standard_args)
    CMakeLists.txt:52 (find_package)

@chenrui333 chenrui333 changed the title wdc: remove openssl dep wdc: mark openssl as build dep Jun 24, 2023
@chenrui333
wdc: mark openssl as build dep
fbb55b2 
Signed-off-by: Rui Chen <rui@chenrui.dev>

wdc: remove openssl from test

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Jun 24, 2023
@p-linnane p-linnane merged commit 6478a87 into Homebrew:openssl-migration-staging Jun 25, 2023
@github-actions github-actions Bot added the outdated PR was locked due to age label Jul 26, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 26, 2023
@chenrui333 chenrui333 deleted the wdc-openssl3 branch January 22, 2024 14:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@p-linnane p-linnane p-linnane approved these changes

Assignees

No one assigned

Labels

boost Boost use is a significant feature of the PR or issue CI-no-bottles Merge without publishing bottles missing license Formula has a missing license which should be added openssl-3-migration Related to switching to an OpenSSL 3 dependency outdated PR was locked due to age ready to merge PR can be merged once CI is green staging-branch-pr This pull request targets a *-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chenrui333 @p-linnane