Skip to content

thrift@0.9: mark openssl as build dep#134846

Merged
p-linnane merged 1 commit into
Homebrew:openssl-migration-stagingfrom
chenrui333:thrift@0.9-openssl3
Jun 24, 2023
Merged

thrift@0.9: mark openssl as build dep#134846
p-linnane merged 1 commit into
Homebrew:openssl-migration-stagingfrom
chenrui333:thrift@0.9-openssl3

Conversation

@chenrui333

@chenrui333 chenrui333 commented Jun 24, 2023

Copy link
Copy Markdown
Member

See #134251.

@chenrui333 chenrui333 added openssl-3-migration Related to switching to an OpenSSL 3 dependency staging-branch-pr This pull request targets a *-staging branch. labels Jun 24, 2023
@chenrui333 chenrui333 mentioned this pull request Jun 24, 2023
Closed
@chenrui333 chenrui333 force-pushed the thrift@0.9-openssl3 branch from ae64922 to 61ffb9a Compare June 24, 2023 03:09
@github-actions github-actions Bot added legacy Relates to a versioned @ formula boost Boost use is a significant feature of the PR or issue labels Jun 24, 2023
@chenrui333

chenrui333 commented Jun 24, 2023

Copy link
Copy Markdown
Member Author

No openssl linkage, remove the dependency instead.

@chenrui333 chenrui333 force-pushed the thrift@0.9-openssl3 branch from 61ffb9a to cedc875 Compare June 24, 2023 04:34
@chenrui333 chenrui333 added the CI-no-bottles Merge without publishing bottles label Jun 24, 2023
@chenrui333

chenrui333 commented Jun 24, 2023

Copy link
Copy Markdown
Member Author 
  libtool: compile:  clang++ -DHAVE_CONFIG_H -I. -I../.. -I../../lib/cpp/src/thrift -I./src -D__STDC_LIMIT_MACROS -Wall -Wextra -pedantic -g -O2 -c src/thrift/transport/TSSLSocket.cpp  -fno-common -DPIC -o src/thrift/transport/.libs/TSSLSocket.o
  src/thrift/transport/TSSLSocket.cpp:33:10: fatal error: 'openssl/err.h' file not found
  #include <openssl/err.h>
           ^~~~~~~~~~~~~~~
  1 error generated.

@chenrui333
thrift@0.9: mark openssl as build dep
c60e30a 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 force-pushed the thrift@0.9-openssl3 branch from cedc875 to c60e30a Compare June 24, 2023 04:49
@chenrui333 chenrui333 changed the title thrift@0.9: switch to openssl@3 thrift@0.9: mark openssl as build dep Jun 24, 2023
@p-linnane p-linnane merged commit fe77dab into Homebrew:openssl-migration-staging Jun 24, 2023
@SMillerDev

SMillerDev commented Jun 24, 2023

Copy link
Copy Markdown
Member

This should really be disabled, it is not supported at all by upstream

@chenrui333 chenrui333 deleted the thrift@0.9-openssl3 branch January 22, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@p-linnane p-linnane p-linnane approved these changes

Assignees

No one assigned

Labels

boost Boost use is a significant feature of the PR or issue CI-no-bottles Merge without publishing bottles legacy Relates to a versioned @ formula openssl-3-migration Related to switching to an OpenSSL 3 dependency staging-branch-pr This pull request targets a *-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chenrui333 @SMillerDev @p-linnane