snapcraft: switch to openssl@3#134749
Merged
Merged
Conversation
d578a26 to
95a483b
Compare
carlocab
commented
Jun 23, 2023
Comment on lines
95
to
99
Member
There was a problem hiding this comment.
Looks like --ignore-installed prevents pip from removing the newer version, so it isn't possible to downgrade setuptools with the DSL.
Member
There was a problem hiding this comment.
Then might be specific to setuptools or some undefined behavior.
In case of pip, I locally tried installing older pip in venv and the output version numbers are all over the place (pip install shows wheel is for 22.3.1 but then claims to have installed 23.0.1. Afterward, pip list still shows 23.0.1 but importing pip shows 22.3.1):
❯ pip list
Package Version
---------- -------
pip 23.0.1
setuptools 67.6.1
❯ pip install -vvv --no-deps --no-binary :all: --ignore-installed ./pip-22.3.1/
Using pip 23.0.1 from /private/tmp/test-venv/venv/lib/python3.11/site-packages/pip (python 3.11)
...
Created wheel for pip: filename=pip-22.3.1-py3-none-any.whl size=2051532 sha256=fdc1a1a2e7a8d5285b5d60bc1a1e6344845e395df4d70049eb69dcf21f9fe7e6
Stored in directory: /Users/cho-m/Library/Caches/pip/wheels/c0/bd/3d/b1f9df2824bf1974a39b5c47d6b437cb4fd7628bcb5f486efa
Successfully built pip
Installing collected packages: pip
changing mode of /private/tmp/test-venv/venv/bin/pip to 755
changing mode of /private/tmp/test-venv/venv/bin/pip3 to 755
changing mode of /private/tmp/test-venv/venv/bin/pip3.11 to 755
Successfully installed pip-23.0.1
Remote version of pip: 23.1.2
Local version of pip: 23.0.1
Was pip installed by pip? True
❯ pip list
Package Version
---------- -------
pip 23.0.1
setuptools 67.6.1
❯ python3 -c 'import pip; print(pip.__version__)'
22.3.1Only difference for setuptools is imported version is also unchanged:
❯ pip install -vvv --no-deps --no-binary :all: --ignore-installed ./setuptools-65.7.0/
Using pip 22.3.1 from /private/tmp/test-venv/venv/lib/python3.11/site-packages/pip (python 3.11)
...
Created wheel for setuptools: filename=setuptools-65.7.0-py3-none-any.whl size=1234046 sha256=0f45194ed9132662327a88c9484237cfddbf7e852866a9d0479f99cc41cb79b2
Stored in directory: /Users/cho-m/Library/Caches/pip/wheels/04/97/31/286624957c941070bd12d9bdf8c69f98b7306bd4aadbdf9067
Successfully built setuptools
Installing collected packages: setuptools
Successfully installed setuptools-67.6.1
❯ pip list
Package Version
---------- -------
pip 23.0.1
setuptools 67.6.1
❯ python3 -c 'import setuptools; print(setuptools.__version__)'
67.6.195a483b to
b097e4e
Compare
13 tasks
nandahkrishna
approved these changes
Jul 2, 2023
Contributor
|
🤖 An automated task has requested bottles to be published to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #134251. This has linkage with
openssl@1.1.