Skip to content

openssh: switch to openssl@3#134721

Merged
BrewTestBot merged 2 commits into
Homebrew:openssl-migration-stagingfrom
carlocab:openssh-part2-openssl3
Jun 23, 2023
Merged

openssh: switch to openssl@3#134721
BrewTestBot merged 2 commits into
Homebrew:openssl-migration-stagingfrom
carlocab:openssh-part2-openssl3

Conversation

@carlocab

@carlocab carlocab commented Jun 23, 2023

Copy link
Copy Markdown
Member

See #134251.

Split off from #134299 to unblock migration of ldns.

@carlocab carlocab added openssl-3-migration Related to switching to an OpenSSL 3 dependency staging-branch-pr This pull request targets a *-staging branch. labels Jun 23, 2023
@carlocab

carlocab commented Jun 23, 2023

Copy link
Copy Markdown
Member Author

Needs:

@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jun 23, 2023
@carlocab carlocab force-pushed the openssh-part2-openssl3 branch from 9575a78 to a433a89 Compare June 23, 2023 14:24
@p-linnane p-linnane mentioned this pull request Jun 23, 2023
Closed
@carlocab

carlocab commented Jun 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

Failing on master too:

❯ lldb -- ./ssh-keygen -A
(lldb) target create "./ssh-keygen"
Current executable set to '/tmp/openssh-20230623-7195-4d1ep3/openssh-9.3p1/ssh-keygen' (x86_64).
(lldb) settings set -- target.run-args  "-A"
(lldb) r
Process 15308 launched: '/tmp/openssh-20230623-7195-4d1ep3/openssh-9.3p1/ssh-keygen' (x86_64)
Process 15308 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
    frame #0: 0x000000010000300e ssh-keygen`main(argc=0, argv=0x0000000000000000) at ssh-keygen.c:3355:32 [opt]
   3352         /* Ensure that fds 0, 1 and 2 are open or directed to /dev/null */
   3353         sanitise_stdfd();
   3354
-> 3355         __progname = ssh_get_progname(argv[0]);
   3356
   3357         seed_rng();
   3358
Target 0: (ssh-keygen) stopped.
warning: ssh-keygen was compiled with optimization - stepping may behave oddly; variables may not be available.
(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
  * frame #0: 0x000000010000300e ssh-keygen`main(argc=0, argv=0x0000000000000000) at ssh-keygen.c:3355:32 [opt]
    frame #1: 0x00007ff80f3fb41f dyld`start + 1903

The issue is that argv is a null pointer??

(lldb) fr v argv
(char **) argv = 0x0000000000000000

@carlocab carlocab added help wanted Task(s) needing PRs from the community or maintainers upstream issue An upstream issue report is needed build failure CI fails while building the software labels Jun 23, 2023
@carlocab carlocab force-pushed the openssh-part2-openssl3 branch from a433a89 to c2c04ec Compare June 23, 2023 15:18
carlocab
carlocab commented Jun 23, 2023
View reviewed changes
Comment thread Formula/openssh.rb Outdated

@carlocab carlocab Jun 23, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a version check here to try to make sure it's addressed at least at the next version bump.

@carlocab carlocab added ready to merge PR can be merged once CI is green and removed help wanted Task(s) needing PRs from the community or maintainers build failure CI fails while building the software labels Jun 23, 2023
@carlocab carlocab force-pushed the openssh-part2-openssl3 branch from c2c04ec to 8fd80ef Compare June 23, 2023 16:04
@carlocab

carlocab commented Jun 23, 2023

Copy link
Copy Markdown
Member Author

@Bo98 @fxcoudert Do you think this is a compiler bug? Only happening on Intel macOS 13. Using ENV.O0 makes it go away.

@Bo98

Bo98 commented Jun 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

argv being null is maybe(?) ok where argc == 0 - will need to read specs to see. Is argc always 0 or something?

Does -O0 actually fix argc or just make argv point somewhere valid but empty?

@github-actions

github-actions Bot commented Jun 23, 2023

Copy link
Copy Markdown
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions Bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jun 23, 2023
@BrewTestBot BrewTestBot enabled auto-merge June 23, 2023 16:28
@Bo98

Bo98 commented Jun 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

argv being null is maybe(?) ok where argc == 0 - will need to read specs to see.

Ah no it isn't according to the C standard:

argv[argc] shall be a null pointer.

Seems like a compiler bug then.

@BrewTestBot BrewTestBot merged commit b2fcd08 into Homebrew:openssl-migration-staging Jun 23, 2023
@carlocab carlocab deleted the openssh-part2-openssl3 branch June 23, 2023 16:57
@github-actions github-actions Bot added the outdated PR was locked due to age label Jul 24, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@p-linnane p-linnane p-linnane approved these changes

Assignees

No one assigned

Labels

CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. openssl-3-migration Related to switching to an OpenSSL 3 dependency outdated PR was locked due to age ready to merge PR can be merged once CI is green staging-branch-pr This pull request targets a *-staging branch. upstream issue An upstream issue report is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@carlocab @Bo98 @p-linnane @BrewTestBot