Skip to content

metview: switch to openssl@3#134679

Merged
BrewTestBot merged 2 commits into
Homebrew:openssl-migration-stagingfrom
carlocab:metview-openssl3
Jun 24, 2023
Merged

metview: switch to openssl@3#134679
BrewTestBot merged 2 commits into
Homebrew:openssl-migration-stagingfrom
carlocab:metview-openssl3

Conversation

@carlocab

@carlocab carlocab commented Jun 22, 2023

Copy link
Copy Markdown
Member

This has linkage with openssl@1.1. Spotted in #134638.

@carlocab carlocab added openssl-3-migration Related to switching to an OpenSSL 3 dependency staging-branch-pr This pull request targets a *-staging branch. labels Jun 22, 2023
@iMichka

iMichka commented Jun 22, 2023

Copy link
Copy Markdown
Member 
2023-06-22T20:18:01.0539506Z [ 63%] Building C object mars-client/src/CMakeFiles/marsclient.dir/account.c.o
2023-06-22T20:18:01.0543409Z cd /tmp/metview-20230622-36665-80inxb/MetviewBundle-2023.4.1-Source/build/mars-client/src && /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/shims/linux/super/gcc-11 -DLITTLE_END -DNOFDB -DNOFDB5 -DNOODB -DR64 -Dmarsclient_EXPORTS -I/tmp/metview-20230622-36665-80inxb/MetviewBundle-2023.4.1-Source/build/mars-client/src -I/tmp/metview-20230622-36665-80inxb/MetviewBundle-2023.4.1-Source/mars-client/src -I/tmp/metview-20230622-36665-80inxb/MetviewBundle-2023.4.1-Source/mir/src -I/tmp/metview-20230622-36665-80inxb/MetviewBundle-2023.4.1-Source/build/mir/src -I/tmp/metview-20230622-36665-80inxb/MetviewBundle-2023.4.1-Source/build/eckit/src -I/tmp/metview-20230622-36665-80inxb/MetviewBundle-2023.4.1-Source/eckit/src -I/tmp/metview-20230622-36665-80inxb/MetviewBundle-2023.4.1-Source/atlas/src -I/tmp/metview-20230622-36665-80inxb/MetviewBundle-2023.4.1-Source/build/atlas/src -I/tmp/metview-20230622-36665-80inxb/MetviewBundle-2023.4.1-Source/atlas/atlas_io/src -I/tmp/metview-20230622-36665-80inxb/MetviewBundle-2023.4.1-Source/build/atlas/atlas_io/src -I/usr/include/tirpc -I/home/linuxbrew/.linuxbrew/include/eigen3 -pipe -O3 -DNDEBUG -fPIC -MD -MT mars-client/src/CMakeFiles/marsclient.dir/account.c.o -MF CMakeFiles/marsclient.dir/account.c.o.d -o CMakeFiles/marsclient.dir/account.c.o -c /tmp/metview-20230622-36665-80inxb/MetviewBundle-2023.4.1-Source/mars-client/src/account.c
2023-06-22T20:18:01.0543876Z In file included from /tmp/metview-20230622-36665-80inxb/MetviewBundle-2023.4.1-Source/mars-client/src/account.c:15:
2023-06-22T20:18:01.0544385Z /tmp/metview-20230622-36665-80inxb/MetviewBundle-2023.4.1-Source/mars-client/src/mars.h:39:10: fatal error: rpc/rpc.h: No such file or directory
2023-06-22T20:18:01.0544503Z    39 | #include <rpc/rpc.h>
2023-06-22T20:18:01.0544601Z       |          ^~~~~~~~~~~
2023-06-22T20:18:01.0544722Z compilation terminated.
2023-06-22T20:18:01.0545191Z make[2]: *** [mars-client/src/CMakeFiles/marsclient.dir/build.make:102: mars-client/src/CMakeFiles/marsclient.dir/account.c.o] Error 1
2023-06-22T20:18:01.0545593Z make[2]: Leaving directory '/tmp/metview-20230622-36665-80inxb/MetviewBundle-2023.4.1-Source/build'
2023-06-22T20:18:01.0545960Z make[1]: *** [CMakeFiles/Makefile2:12424: mars-client/src/CMakeFiles/marsclient.dir/all] Error 2
2023-06-22T20:18:01.0546100Z make[1]: *** Waiting for unfinished jobs....
2023-06-22T20:18:01.0546260Z [ 63%] Linking CXX executable mir_tests_unit_atlas
2023-06-22T20:18:01.0546848Z cd /tmp/metview-20230622-36665-80inxb/MetviewBundle-2023.4.1-Source/build/mir/tests/unit && /home/linuxbrew/.linuxbrew/Cellar/cmake/3.26.4/bin/cmake -E remove EXE_FILENAME-NOTFOUND
2023-06-22T20:18:01.0547540Z cd /tmp/metview-20230622-36665-80inxb/MetviewBundle-2023.4.1-Source/build/mir/tests/unit && /home/linuxbrew/.linuxbrew/Cellar/cmake/3.26.4/bin/cmake -E cmake_link_script CMakeFiles/mir_tests_unit_atlas.dir/link.txt --verbose=1

@cho-m

cho-m commented Jun 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Build is picking up the wrong include directory (/usr/include/tirpc) and looks like the CMAKE_CXX_FLAGS didn't help when building mars-client

  -- Found RPC: /home/linuxbrew/.linuxbrew/lib/libtirpc.so  
  -- mars_client FOUND RPC
  --    RPC_INCLUDE_DIRS : [/usr/include/tirpc]
  --    RPC_LIBRARIES : [/home/linuxbrew/.linuxbrew/lib/libtirpc.so]

RPC_PATH=HOMEBREW_PREFIX probably isn't working as it is missing the tirpc subdirectory (include/tirpc/rpc/rpc.h) when searching for header:

    if( NOT RPC_PATH )
        if ( NOT "$ENV{RPC_PATH}" STREQUAL "" )
            set( RPC_PATH "$ENV{RPC_PATH}" )
        elseif ( NOT "$ENV{RPC_DIR}" STREQUAL "" )
            set( RPC_PATH "$ENV{RPC_DIR}" )
        endif()
    endif()

    find_path(RPC_INCLUDE_DIR NAMES rpc/rpc.h PATHS ${RPC_PATH} ${RPC_PATH}/include /usr/include /usr/include/tirpc NO_DEFAULT_PATH )

On side note, -DFFTW_PATH=#{HOMEBREW_PREFIX} is not being expanded:

homebrew-core/Formula/metview.rb

Lines 51 to 56 in 03af856

args = %w[
-DBUNDLE_SKIP_ECCODES=1
-DENABLE_MIR_DOWNLOAD_MASKS=OFF
-DENABLE_BUILD_TOOLS=OFF
-DENABLE_ECKIT_CMD=OFF
-DFFTW_PATH=#{HOMEBREW_PREFIX}

@carlocab carlocab mentioned this pull request Jun 23, 2023
Closed
carlocab
carlocab commented Jun 23, 2023
View reviewed changes
Comment thread Formula/metview.rb Outdated
cho-m
cho-m reviewed Jun 23, 2023
View reviewed changes
Comment thread Formula/metview.rb Outdated
@github-actions github-actions Bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jun 23, 2023
@carlocab @cho-m
metview: switch to openssl@3
d0ba070 
This has linkage with `openssl@1.1`. Spotted in Homebrew#134638.

Co-authored-by: Michael Cho <cho-m@tuta.io>
@github-actions github-actions Bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jun 23, 2023
@carlocab carlocab added the ready to merge PR can be merged once CI is green label Jun 23, 2023
@github-actions

github-actions Bot commented Jun 24, 2023

Copy link
Copy Markdown
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions Bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jun 24, 2023
@BrewTestBot BrewTestBot enabled auto-merge June 24, 2023 02:38
@BrewTestBot BrewTestBot merged commit 1843f48 into Homebrew:openssl-migration-staging Jun 24, 2023
@carlocab carlocab deleted the metview-openssl3 branch June 24, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cho-m cho-m cho-m left review comments

@nandahkrishna nandahkrishna nandahkrishna approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

No one assigned

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. openssl-3-migration Related to switching to an OpenSSL 3 dependency ready to merge PR can be merged once CI is green staging-branch-pr This pull request targets a *-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@carlocab @iMichka @cho-m @nandahkrishna @BrewTestBot