Skip to content

sphinx: switch to openssl@3#134658

Closed
mchoo7 wants to merge 1 commit into
Homebrew:openssl-migration-stagingfrom
mchoo7:sphinx-openssl3
Closed

sphinx: switch to openssl@3#134658
mchoo7 wants to merge 1 commit into
Homebrew:openssl-migration-stagingfrom
mchoo7:sphinx-openssl3

Conversation

@mchoo7

@mchoo7 mchoo7 commented Jun 22, 2023

Copy link
Copy Markdown
Contributor

See #134251.

@github-actions github-actions Bot added the formula deprecated Formula deprecated label Jun 22, 2023
@mchoo7

mchoo7 commented Jun 22, 2023

Copy link
Copy Markdown
Contributor Author

sphinx github repo

This is the 2.x branch, not really supported or actively developed as of 2018.

The source code of 3.x is not released yet.
I think 2.x doesn't support openssl@3.

@carlocab carlocab added openssl-3-migration Related to switching to an OpenSSL 3 dependency staging-branch-pr This pull request targets a *-staging branch. labels Jun 22, 2023
@chenrui333

This comment was marked as resolved.

Sign in to view
@mchoo7 mchoo7 force-pushed the sphinx-openssl3 branch from b9f92ba to 24ab490 Compare June 23, 2023 22:44
@mchoo7

This comment was marked as resolved.

Sign in to view
@mchoo7 mchoo7 mentioned this pull request Jun 24, 2023
Closed
chenrui333
chenrui333 reviewed Jun 25, 2023
View reviewed changes
Comment thread Formula/sphinx.rb Outdated
@chenrui333 chenrui333 added CI-no-bottles Merge without publishing bottles and removed CI-no-bottles Merge without publishing bottles labels Jun 25, 2023
@mchoo7 @chenrui333
sphinx: switch to openssl@3
8ea85bd 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@github-actions github-actions Bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jun 25, 2023
@github-actions github-actions Bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jun 25, 2023
@chenrui333

chenrui333 commented Jun 25, 2023

Copy link
Copy Markdown
Member

it does have openssl linkage for macos builds, see run, https://github.com/Homebrew/homebrew-core/actions/runs/5361110431/jobs/9726804943

@mchoo7

mchoo7 commented Jun 25, 2023

Copy link
Copy Markdown
Contributor Author

it does have openssl linkage for macos builds, see run, https://github.com/Homebrew/homebrew-core/actions/runs/5361110431/jobs/9726804943

#134421
mysql@5.7 won't support openssl@3. I think sphinx will be deprecated when mysql@5.7 deprecates in October. Even if we add support for openssl@3 here, it will conflict with openssl@1.1 for mysql@5.7.

@carlocab

carlocab commented Jun 26, 2023

Copy link
Copy Markdown
Member

Closing since we can't migrate mysql@5.7. Thanks anyway @fel1x-developer!

@carlocab carlocab closed this Jun 26, 2023
@mchoo7 mchoo7 deleted the sphinx-openssl3 branch June 26, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenrui333 chenrui333 chenrui333 left review comments

Assignees

No one assigned

Labels

formula deprecated Formula deprecated openssl-3-migration Related to switching to an OpenSSL 3 dependency staging-branch-pr This pull request targets a *-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mchoo7 @chenrui333 @carlocab