Skip to content

sslsplit: switch to openssl@3#134598

Merged
BrewTestBot merged 2 commits into
Homebrew:openssl-migration-stagingfrom
chenrui333:sslsplit-openssl3
Jun 24, 2023
Merged

sslsplit: switch to openssl@3#134598
BrewTestBot merged 2 commits into
Homebrew:openssl-migration-stagingfrom
chenrui333:sslsplit-openssl3

Conversation

@chenrui333

Copy link
Copy Markdown
Member

See #134251.

@chenrui333 chenrui333 added openssl-3-migration Related to switching to an OpenSSL 3 dependency staging-branch-pr This pull request targets a *-staging branch. labels Jun 22, 2023
@chenrui333

Copy link
Copy Markdown
Member Author
  gcc-11 -L/home/linuxbrew/.linuxbrew/opt/libnet/lib -L/home/linuxbrew/.linuxbrew/Cellar/openssl@3/3.1.1/lib -L/home/linuxbrew/.linuxbrew/Cellar/libevent/2.1.12_1/lib -L/home/linuxbrew/.linuxbrew/Cellar/libpcap/1.10.4/lib -Wl,-rpath,/home/linuxbrew/.linuxbrew/Cellar/libpcap/1.10.4/lib -pthread -o sslsplit base64.o build.o cache.o cachedsess.o cachefkcrt.o cachemgr.o cachessess.o cachetgcrt.o cert.o dynbuf.o log.o logbuf.o logger.o logpkt.o main.o nat.o opts.o privsep.o proc.o proxy.o pxyconn.o pxythrmgr.o ssl.o sys.o thrqueue.o url.o util.o -lnet -lssl -lcrypto -levent_openssl -levent_pthreads -levent -lpcap
  /usr/bin/ld: pxyconn.o: in function `pxy_bev_eventcb':
  pxyconn.c:(.text+0x3418): undefined reference to `ERR_GET_FUNC'
  /usr/bin/ld: pxyconn.c:(.text+0x3483): undefined reference to `ERR_GET_FUNC'
  /usr/bin/ld: pxyconn.c:(.text+0x356c): undefined reference to `ERR_GET_FUNC'
  /usr/bin/ld: pxyconn.c:(.text+0x39a2): undefined reference to `ERR_GET_FUNC'
  /usr/bin/ld: pxyconn.c:(.text+0x3aa0): undefined reference to `ERR_GET_FUNC'
  /usr/bin/ld: pxyconn.o:pxyconn.c:(.text+0x412c): more undefined references to `ERR_GET_FUNC' follow
  collect2: error: ld returned 1 exit status

@chenrui333 chenrui333 added build failure CI fails while building the software linux Linux is specifically affected labels Jun 22, 2023
@Bo98

Bo98 commented Jun 22, 2023

Copy link
Copy Markdown
Member

droe/sslsplit@e17de84

@p-linnane p-linnane force-pushed the sslsplit-openssl3 branch 2 times, most recently from d4e7a08 to fdad8bc Compare June 22, 2023 22:51
@chenrui333

Copy link
Copy Markdown
Member Author
  ==> (/home/linuxbrew/.linuxbrew/Cellar/sslsplit/0.5.5_2/bin/sslsplit -D http 0.0.0.0 36763 www.roe.ch 80 & PID=$! && sleep 3 ; kill $PID) 2>&1
  Error: sslsplit: failed
  An exception occurred within a child process:
    Minitest::Assertion: Expected /Starting\ main\ event\ loop/ to match "".

@chenrui333 chenrui333 added test failure CI fails while running the test-do block and removed build failure CI fails while building the software labels Jun 23, 2023
@cho-m cho-m added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-requeued PR has been re-added to the queue and removed test failure CI fails while running the test-do block linux Linux is specifically affected labels Jun 24, 2023
@cho-m

cho-m commented Jun 24, 2023

Copy link
Copy Markdown
Member

No issues on re-run. Probably a timing issue.

Patch should only be for stable to avoid breaking HEAD build, but low priority and can be ignored if we want to merge as-is.

Signed-off-by: Rui Chen <rui@chenrui.dev>

sslsplit: add `openssl@3` patch
@carlocab carlocab force-pushed the sslsplit-openssl3 branch from fdad8bc to 73acb5a Compare June 24, 2023 09:00
@carlocab carlocab added the ready to merge PR can be merged once CI is green label Jun 24, 2023
@github-actions

Copy link
Copy Markdown
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions Bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jun 24, 2023
@BrewTestBot BrewTestBot enabled auto-merge June 24, 2023 14:35
@BrewTestBot BrewTestBot merged commit 1b549d7 into Homebrew:openssl-migration-staging Jun 24, 2023
@github-actions github-actions Bot added the outdated PR was locked due to age label Jul 25, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 25, 2023
@chenrui333 chenrui333 deleted the sslsplit-openssl3 branch January 22, 2024 14:27
@chenrui333 chenrui333 removed the CI-requeued PR has been re-added to the queue label Jan 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. openssl-3-migration Related to switching to an OpenSSL 3 dependency outdated PR was locked due to age ready to merge PR can be merged once CI is green staging-branch-pr This pull request targets a *-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants