Skip to content

monkeysphere: switch to openssl@3#134557

Merged
BrewTestBot merged 2 commits into
Homebrew:openssl-migration-stagingfrom
chenrui333:monkeysphere-openssl3
Jun 26, 2023
Merged

monkeysphere: switch to openssl@3#134557
BrewTestBot merged 2 commits into
Homebrew:openssl-migration-stagingfrom
chenrui333:monkeysphere-openssl3

Conversation

@chenrui333

@chenrui333 chenrui333 commented Jun 22, 2023

Copy link
Copy Markdown
Member

See #134251.

@chenrui333 chenrui333 added openssl-3-migration Related to switching to an OpenSSL 3 dependency staging-branch-pr This pull request targets a *-staging branch. labels Jun 22, 2023
@github-actions github-actions Bot added the perl Perl use is a significant feature of the PR or issue label Jun 22, 2023
@chenrui333 chenrui333 mentioned this pull request Jun 22, 2023
Closed
@chenrui333

chenrui333 commented Jun 22, 2023

Copy link
Copy Markdown
Member Author 
  RSA.xs:647:22: error: ‘RSA_SSLV23_PADDING’ undeclared (first use in this function); did you mean ‘RSA_NO_PADDING’?
    647 |     p_rsa->padding = RSA_SSLV23_PADDING;
        |                      ^~~~~~~~~~~~~~~~~~
        |                      RSA_NO_PADDING
  RSA.xs:647:22: note: each undeclared identifier is reported only once for each function it appears in

@chenrui333 chenrui333 added the build failure CI fails while building the software label Jun 22, 2023
@cho-m

cho-m commented Jun 23, 2023

Copy link
Copy Markdown
Member

Probably need to update resources.

@carlocab carlocab force-pushed the monkeysphere-openssl3 branch from 200a1fb to a41d824 Compare June 23, 2023 16:26
@carlocab carlocab added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. test failure CI fails while running the test-do block and removed build failure CI fails while building the software labels Jun 23, 2023
@cho-m

cho-m commented Jun 23, 2023

Copy link
Copy Markdown
Member

On ARM:

  ==> /opt/homebrew/Cellar/monkeysphere/0.44_6/bin/openpgp2pem --help 2>&1
  sh: line 1: 10910 Abort trap: 6           /opt/homebrew/Cellar/monkeysphere/0.44_6/bin/openpgp2pem --help 2>&1
  Error: monkeysphere: failed
  An exception occurred within a child process:
    Minitest::Assertion: Expected /We\ need\ at\ least/ to match "dyld[10910]: missing symbol called\n".

@cho-m

cho-m commented Jun 24, 2023

Copy link
Copy Markdown
Member

Probably issue linking to OpenSSL.

Can either add pkg-config as build dependency or manually set OPENSSL_PREFIX.

@chenrui333

chenrui333 commented Jun 25, 2023

Copy link
Copy Markdown
Member Author

Probably issue linking to OpenSSL.

Can either add pkg-config as build dependency or manually set OPENSSL_PREFIX.

yeah, we can try pkg-config route

@chenrui333
monkeysphere: switch to openssl@3
c59b4fa 
Signed-off-by: Rui Chen <rui@chenrui.dev>

monkeysphere: depends_on pkg-config for arm builds

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 force-pushed the monkeysphere-openssl3 branch from a41d824 to c59b4fa Compare June 25, 2023 01:11
@chenrui333 chenrui333 added the CI-requeued PR has been re-added to the queue label Jun 25, 2023
@carlocab carlocab removed the test failure CI fails while running the test-do block label Jun 26, 2023
@github-actions

github-actions Bot commented Jun 26, 2023

Copy link
Copy Markdown
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions Bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jun 26, 2023
@BrewTestBot BrewTestBot enabled auto-merge June 26, 2023 05:08
@BrewTestBot BrewTestBot merged commit 98091d2 into Homebrew:openssl-migration-staging Jun 26, 2023
@chenrui333 chenrui333 deleted the monkeysphere-openssl3 branch January 22, 2024 14:27
@chenrui333 chenrui333 removed the CI-requeued PR has been re-added to the queue label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlocab carlocab carlocab approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

No one assigned

Labels

CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. openssl-3-migration Related to switching to an OpenSSL 3 dependency perl Perl use is a significant feature of the PR or issue staging-branch-pr This pull request targets a *-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chenrui333 @cho-m @carlocab @BrewTestBot