Skip to content

fb303, fbthrift, fizz, folly, wangle, watchman: switch to openssl@3#134474

Merged
BrewTestBot merged 14 commits into
Homebrew:openssl-migration-stagingfrom
krehel:fizz-openssl3
Jun 23, 2023
Merged

fb303, fbthrift, fizz, folly, wangle, watchman: switch to openssl@3#134474
BrewTestBot merged 14 commits into
Homebrew:openssl-migration-stagingfrom
krehel:fizz-openssl3

Conversation

@krehel

@krehel krehel commented Jun 21, 2023

Copy link
Copy Markdown
Member

See #134251

@github-actions github-actions Bot added the boost Boost use is a significant feature of the PR or issue label Jun 21, 2023
@krehel krehel added openssl-3-migration Related to switching to an OpenSSL 3 dependency staging-branch-pr This pull request targets a *-staging branch. boost Boost use is a significant feature of the PR or issue and removed boost Boost use is a significant feature of the PR or issue labels Jun 21, 2023
@krehel krehel mentioned this pull request Jun 21, 2023
Closed
@p-linnane

p-linnane commented Jun 21, 2023

Copy link
Copy Markdown
Member

We are going to have to do the whole Facebook suite in one PR (edencommon, fb303, fbthrift, fizz, folly, wangle, watchman)

@krehel

krehel commented Jun 21, 2023

Copy link
Copy Markdown
Member Author

Thanks @p-linnane - I'll close this

@krehel krehel closed this Jun 21, 2023
@p-linnane

p-linnane commented Jun 21, 2023

Copy link
Copy Markdown
Member

You can just push the updates to all the other ones here and we can run it.

@krehel

krehel commented Jun 22, 2023

Copy link
Copy Markdown
Member Author

Sounds good @p-linnane!

@krehel krehel reopened this Jun 22, 2023
@krehel krehel changed the title fizz: switch to openssl@3 fb303, fbthrift, fizz, folly, wangle, watchman: switch to openssl@3 Jun 22, 2023
@krehel

krehel commented Jun 22, 2023

Copy link
Copy Markdown
Member Author

Note that edencommon did not appear to have a dependency on openssl and therefore was not updated

@p-linnane

p-linnane commented Jun 22, 2023

Copy link
Copy Markdown
Member

fb303 has no linkage with openssl@3 on Linux.

cc @carlocab

carlocab
carlocab approved these changes Jun 23, 2023
View reviewed changes

@carlocab carlocab left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fb303 has no linkage with openssl@3 on Linux.

That's fine, it didn't have linkage with openssl@1.1 on Linux either.

@github-actions

github-actions Bot commented Jun 23, 2023

Copy link
Copy Markdown
Contributor

:shipit: @carlocab has requested bottles to be published to this PR.

@github-actions github-actions Bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jun 23, 2023
@BrewTestBot BrewTestBot enabled auto-merge June 23, 2023 10:07
@BrewTestBot BrewTestBot merged commit 8633775 into Homebrew:openssl-migration-staging Jun 23, 2023
@krehel krehel deleted the fizz-openssl3 branch June 28, 2023 00:13
@github-actions github-actions Bot added the outdated PR was locked due to age label Jul 28, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@carlocab carlocab carlocab approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

No one assigned

Labels

boost Boost use is a significant feature of the PR or issue CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. openssl-3-migration Related to switching to an OpenSSL 3 dependency outdated PR was locked due to age staging-branch-pr This pull request targets a *-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@krehel @p-linnane @carlocab @BrewTestBot