Skip to content

ruby@3.0: switch to openssl@3#134430

Merged
BrewTestBot merged 2 commits into
Homebrew:masterfrom
carlocab:ruby30-openssl3
Jun 23, 2023
Merged

ruby@3.0: switch to openssl@3#134430
BrewTestBot merged 2 commits into
Homebrew:masterfrom
carlocab:ruby30-openssl3

Conversation

@carlocab

Copy link
Copy Markdown
Member
  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@carlocab carlocab added the openssl-3-migration Related to switching to an OpenSSL 3 dependency label Jun 21, 2023
@github-actions github-actions Bot added the legacy Relates to a versioned @ formula label Jun 21, 2023
@chenrui333 chenrui333 added the test failure CI fails while running the test-do block label Jun 21, 2023
@cho-m

cho-m commented Jun 23, 2023

Copy link
Copy Markdown
Member

Can try updating Ruby's openssl gem similar to ArchLinux: https://gitlab.archlinux.org/archlinux/packaging/packages/ruby/-/blob/main/PKGBUILD#L27-31

@github-actions github-actions Bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jun 23, 2023
Also, update the `openssl` gem for compatibility with our `openssl@3`.
@github-actions github-actions Bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Jun 23, 2023
@carlocab carlocab added ready to merge PR can be merged once CI is green and removed test failure CI fails while running the test-do block labels Jun 23, 2023
@carlocab

Copy link
Copy Markdown
Member Author

Thanks for the tip. Looks like that worked.

@carlocab carlocab requested review from chenrui333 and p-linnane June 23, 2023 18:12

@p-linnane p-linnane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@github-actions

Copy link
Copy Markdown
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions Bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jun 23, 2023
@BrewTestBot BrewTestBot enabled auto-merge June 23, 2023 18:16
@BrewTestBot BrewTestBot added this pull request to the merge queue Jun 23, 2023
Merged via the queue into Homebrew:master with commit 1ec37ac Jun 23, 2023
@carlocab carlocab deleted the ruby30-openssl3 branch June 23, 2023 18:44
@github-actions github-actions Bot added the outdated PR was locked due to age label Jul 24, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. legacy Relates to a versioned @ formula openssl-3-migration Related to switching to an OpenSSL 3 dependency outdated PR was locked due to age ready to merge PR can be merged once CI is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants