Skip to content

coturn: switch to openssl@3#134288

Merged
BrewTestBot merged 2 commits into
Homebrew:openssl-migration-stagingfrom
alebcay:coturn-openssl-migration
Jun 20, 2023
Merged

coturn: switch to openssl@3#134288
BrewTestBot merged 2 commits into
Homebrew:openssl-migration-stagingfrom
alebcay:coturn-openssl-migration

Conversation

@alebcay

@alebcay alebcay commented Jun 20, 2023

Copy link
Copy Markdown
Member
  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@carlocab carlocab added openssl-3-migration Related to switching to an OpenSSL 3 dependency staging-branch-pr This pull request targets a *-staging branch. labels Jun 20, 2023
@alebcay alebcay marked this pull request as draft June 20, 2023 20:48
@alebcay alebcay force-pushed the coturn-openssl-migration branch from caaa554 to 6c60fa7 Compare June 20, 2023 20:51
@alebcay alebcay marked this pull request as ready for review June 20, 2023 20:51
Comment thread Formula/coturn.rb
Comment on lines +31 to +32
ENV["SSL_CFLAGS"] = "-I#{Formula["openssl@3"].opt_include}"
ENV["SSL_LIBS"] = "-L#{Formula["openssl@3"].opt_lib} -lssl -lcrypto"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda weird that these are needed now and not previously.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that it was still picking up my openssl@1.1 when both 1.1 and 3 are present. So it's able to find an OpenSSL installation, just the wrong one.

@github-actions

Copy link
Copy Markdown
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions Bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jun 20, 2023
@BrewTestBot BrewTestBot merged commit c4bcd42 into Homebrew:openssl-migration-staging Jun 20, 2023
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Pre-merge checks failed. CC @carlocab

@github-actions github-actions Bot added the outdated PR was locked due to age label Jul 21, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. openssl-3-migration Related to switching to an OpenSSL 3 dependency outdated PR was locked due to age staging-branch-pr This pull request targets a *-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants