previous run, https://github.com/Homebrew/homebrew-core/actions/runs/5284135267/job/14309307226?pr=133887

only test failure on linux

  ==> /home/linuxbrew/.linuxbrew/Cellar/kafka/3.5.0/bin/kafka-server-stop
  No kafka server to stop
  Killing child processes...
  Error: kafka: failed
  An exception occurred within a child process:
    BuildError: Failed executing: /home/linuxbrew/.linuxbrew/Cellar/kafka/3.5.0/bin/kafka-server-stop

• putting line ENV["COLUMNS"] = "" after ENV["LOG_DIR"] = "#{testpath}/kafkalog" will solve CI problem.

diff --git a/Formula/k/kafka.rb b/Formula/k/kafka.rb
index ed872f218a9..3b0e0239eb9 100644
--- a/Formula/k/kafka.rb
+++ b/Formula/k/kafka.rb
@@ -68,6 +68,7 @@ class Kafka < Formula

   test do
     ENV["LOG_DIR"] = "#{testpath}/kafkalog"
+    ENV["COLUMNS"] = ""

     (testpath/"kafka").mkpath
     cp "#{etc}/kafka/zookeeper.properties", testpath/"kafka"

• this problem is caused by 3 things

  1. brew test-bot sets environment variable COLUMNS for brew test (maybe after Homebrew/brew#15255)
  2. kafka-server-stop script uses ps ax command to determine Process ID of kafka instances (kafka/bin/kafka-server-stop.sh, lines 18-28)
  3. ps command implementation of Ubuntu truncates its output if environment variable COLUMNS is set even if its output is piped (procps-ng/procps/src/ps/global.c, lines 226-230)
     • this is Linux(Ubuntu) specific. because macOS uses its own implementation that ignores COLUMNS if its output is piped (adv_cmds/ps/ps.c, lines 484-488, which follows lines 237-245 where it looks COLUMNS)

• there are some possible fixes

  • treat it as upstream problem of kafka which does not use ps axww to avoid truncation
  • treat it as brew-test-bot problem that causes unexpected environment variable is set for brew test
  • add patch that replaces ps ax to ps axww, to kafka formula

• but, in my thought, because this problem blocks openjdk 20.0.2 which is a security fix, adding ENV["COLUMNS"] = "" is good because it can be applied quickly

Is it possible one of the solutions will be used?

If someone reports the bug upstream I'm fine accepting a workaround in brew

I reported to kafka Jira (KAFKA-15413).

They have some issues about kafka-server-stop script and ps ax truncation for some years. (KAFKA-4931 and KAFKA-4110) So, this report may need long time or be rejected.

Thank you for the fix and upstream report, @miimou.

🤖 An automated task has requested bottles to be published to this PR.

@miimou thanks for getting this forward 💯