Skip to content

luvit: switch to openssl@3#133517

Merged
BrewTestBot merged 2 commits into
Homebrew:masterfrom
carlocab:luvit-openssl
Jun 28, 2023
Merged

luvit: switch to openssl@3#133517
BrewTestBot merged 2 commits into
Homebrew:masterfrom
carlocab:luvit-openssl

Conversation

@carlocab

Copy link
Copy Markdown
Member
  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@carlocab carlocab added the openssl-3-migration Related to switching to an OpenSSL 3 dependency label Jun 13, 2023
@github-actions github-actions Bot added the lua Lua use is a significant feature of the PR or issue label Jun 13, 2023
@carlocab carlocab added help wanted Task(s) needing PRs from the community or maintainers CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jun 13, 2023
@chenrui333

Copy link
Copy Markdown
Member

maybe rebase this PR

@Bo98

Bo98 commented Jun 21, 2023

Copy link
Copy Markdown
Member

Bundled lua-openssl is at 0.8.2 but needs updating to 0.8.3 I think.

@carlocab carlocab force-pushed the luvit-openssl branch 3 times, most recently from a82d36e to 1595798 Compare June 24, 2023 00:34
@carlocab carlocab added ready to merge PR can be merged once CI is green build failure CI fails while building the software linux Linux is specifically affected and removed help wanted Task(s) needing PRs from the community or maintainers ready to merge PR can be merged once CI is green labels Jun 24, 2023
@carlocab

Copy link
Copy Markdown
Member Author

Build fails on Linux with:

 luvi: src/unix/linux.c:918: uv__poll_io_uring: Assertion `uv__has_active_reqs(loop)' failed.

@cho-m cho-m added the CI-requeued PR has been re-added to the queue label Jun 28, 2023
@cho-m

cho-m commented Jun 28, 2023

Copy link
Copy Markdown
Member

Went away on re-run so may be a race condition.

Seems to be happening on call to libuv (https://github.com/libuv/libuv/blob/v1.45.0/src/unix/linux.c#L918) so maybe somewhere in luv.

@carlocab carlocab added ready to merge PR can be merged once CI is green and removed build failure CI fails while building the software labels Jun 28, 2023
@github-actions

Copy link
Copy Markdown
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions Bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jun 28, 2023
@BrewTestBot BrewTestBot enabled auto-merge June 28, 2023 04:34
@BrewTestBot BrewTestBot added this pull request to the merge queue Jun 28, 2023
Merged via the queue into Homebrew:master with commit fc778d1 Jun 28, 2023
@carlocab carlocab deleted the luvit-openssl branch June 28, 2023 08:44
@github-actions github-actions Bot added the outdated PR was locked due to age label Jul 28, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 28, 2023
@chenrui333 chenrui333 removed the CI-requeued PR has been re-added to the queue label Jan 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. linux Linux is specifically affected lua Lua use is a significant feature of the PR or issue openssl-3-migration Related to switching to an OpenSSL 3 dependency outdated PR was locked due to age ready to merge PR can be merged once CI is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants