pypy3.8 (new formula) pypy3.9 (new formula)#126697
Conversation
|
@tonybaloney: thanks for the first 30 commits, I built on that to remove the tklib library |
|
The recipe is failing with but there should be no use of libtcl in the recipe. How can I find out what is going on? |
My understanding of the issue is that PyPy will link to TCL-TK if it is installed, regardless of whether the environment variable is set. https://foss.heptapod.net/pypy/pypy/-/blob/branch/default/lib_pypy/_tkinter/tklib_build.py#L22-28 The issue you're seeing in the build means that PyPy has linked to TCL-TK when it was installed as a dependency of another package (which it shouldn't). The environment variable, |
|
There is additional logic to skip package building when the |
|
|
Just keep tklib, TBH. I'm not sure it's worth the effort trying to excise it. While you're at it, could you try to clean up your branch a little? At minimum, each commit should modify at most one formula at a time. Finally, let's not delete |
That was where #117699 ended up. But it seems there is no way to use the homebrew tk/tcl libraries in a recipe. Is there a way to fix that? |
|
I'm not sure I understand -- the linkage failure is precisely because the build is using Homebrew |
|
When installing homebrew tcl-tk, the build complains But when using macos I don't have MacOSX13 headers on my machine. I do have MacOSX11.3, MacOSX12.1, and MacOSX12.3, and all those have X11 headers. |
That's fine. We can ignore that failure because we know the system one doesn't work. |
Such a fix would allow #117699 to pass tests, and then I can close this PR. |
|
@carlocab what is the incantation to ignore the "Dependency 'tcl-tk' is provided by macOS; please replace 'depends_on' with 'uses_from_macos'" error? |
|
Just leave it be; we can merge this if that's the only error. Please do clean up your branch though. |
Linux build failed in the previous PR. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?Replaces #117699, by adding a single commit to avoid the tklib tcl/tk package (like CPython) since there is a problem with the Apple-provided libraries.