Skip to content

protobuf 22.3, protobuf@21 21.12 (new formula)#123791

Closed
ZhongRuoyu wants to merge 10 commits into
Homebrew:masterfrom
ZhongRuoyu:protobuf-22
Closed

protobuf 22.3, protobuf@21 21.12 (new formula)#123791
ZhongRuoyu wants to merge 10 commits into
Homebrew:masterfrom
ZhongRuoyu:protobuf-22

Conversation

@ZhongRuoyu

Copy link
Copy Markdown
Member
  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Split out from #123507.

protobuf 22.0 carries breaking changes. Given that grpc's support for protobuf 22.0 is still in progress: if we depend grpc on a newly-created protobuf@21, a considerable number of dependents will have to switch to it. So, we'd like to put the protobuf update on hold until grpc supports it.

See discussion in #123507 (comment).

@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Feb 20, 2023
@ZhongRuoyu ZhongRuoyu added the in progress Stale bot should stay away label Feb 20, 2023
@chenrui333 chenrui333 mentioned this pull request Feb 26, 2023
@chenrui333 chenrui333 added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. long build Set a long timeout for formula testing CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Mar 4, 2023
@ZhongRuoyu ZhongRuoyu removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 4, 2023
@carlocab

Copy link
Copy Markdown
Member

Do we have a timeline for when grpc will support the latest protobuf?

@ZhongRuoyu

ZhongRuoyu commented Mar 16, 2023

Copy link
Copy Markdown
Member Author

Do we have a timeline for when grpc will support the latest protobuf?

Couldn't tell from the list of PRs on GitHub but that still seems to be experimental. The gRPC team requires that questions be sent to Google Groups instead, so I did this: https://groups.google.com/g/grpc-io/c/j3JvnUT7rg8

If that's too far away from now, say, two more months, do we want a protobuf@21?

@SMillerDev

Copy link
Copy Markdown
Member

Seems like protobuf@21 is the way to go

@ZhongRuoyu ZhongRuoyu changed the title protobuf 22.0 protobuf 22.0, protobuf@21 21.12 (new formula) Apr 13, 2023
@ZhongRuoyu ZhongRuoyu changed the title protobuf 22.0, protobuf@21 21.12 (new formula) protobuf 22.3, protobuf@21 21.12 (new formula) Apr 13, 2023
ZhongRuoyu and others added 10 commits April 15, 2023 08:53
protobuf: add `abseil` dependency

Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
Following `grpc`'s switch.
Following `grpc`'s switch.
Following `grpc`'s switch.
Following `grpc`'s switch.
Following `grpc`'s switch.
Following `grpc`'s switch.
Following `grpc`'s switch.
@ZhongRuoyu ZhongRuoyu added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Apr 15, 2023
@ZhongRuoyu ZhongRuoyu removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Apr 15, 2023
@carlocab

carlocab commented May 2, 2023

Copy link
Copy Markdown
Member

gRPC can use the latest protobuf in version 1.55. grpc/grpc@0f1afec

@ZhongRuoyu

Copy link
Copy Markdown
Member Author

protobuf 23 support has also landed, and will be backported to 1.55: grpc/grpc#33053

@carlocab

Copy link
Copy Markdown
Member

Cherry-picked onto #131405.

@carlocab carlocab closed this May 19, 2023
@ZhongRuoyu ZhongRuoyu deleted the protobuf-22 branch May 19, 2023 16:16
@github-actions github-actions Bot added the outdated PR was locked due to age label Jun 19, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 19, 2023
@chenrui333 chenrui333 removed the in progress Stale bot should stay away label Jun 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge-skip `brew pr-automerge` will skip this pull request CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants