node@14: deprecate on 2023-04-30 (EOL)#123650
Closed
cho-m wants to merge 4 commits into
Closed
Conversation
ZhongRuoyu
approved these changes
Feb 19, 2023
ZhongRuoyu
left a comment
Member
There was a problem hiding this comment.
👍 for option 1, in line with upstream decision.
Bo98
approved these changes
Feb 19, 2023
Bo98
left a comment
Member
There was a problem hiding this comment.
I say option 1 (deprecate on 2023-04-30) with a full disable date of 2023-09-11.
Member
|
We'll need to discuss strategy regarding OpenSSL 1.1 soon (because of notice periods). We're usually quite strict with security formulae - we outright deleted OpenSSL 1.0 on its EOL date last time so we'll need to discuss when exactly when we deprecate and when we disable (3 months minimum between the two stages). This in turn affects Node 16. |
chenrui333
approved these changes
Feb 19, 2023
Member
|
for option1 (life is easier 😅 ) |
Member
Author
|
Removing |
Contributor
|
🤖 A scheduled task has triggered a merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Planning for upcoming
node@14EOL.Checking for maintainer feedback on how we want to handle this, e.g.
Option 1 (2023-04-30): Approach in PR where we deprecate
node@14on EOL to prevent new usage inhomebrew-coreand we start a removal time limit on dependents that are still using EOLnode@14.Option 2 (2023-09-11): We can extend deprecation to at latest
openssl@1.1EOL (2023-09-11) and move date earlier upon any CVE. Based on other repositories, it looks likenode@14does not support OpenSSL 3. We probably do not want any non-deprecated formulae using OpenSSL 1.1 after EOL, so that date would be latest we could delay.As note, both
balena-cliandopensearch-dashboardswere stuck on EOL NodeJS (node@12andnode@10respectively) for a while.